spectrum-web-components
spectrum-web-components copied to clipboard
Published
20 hours ago •
adobe
adobe
removal: darkest theme references
trafficstars
Description
Removed darkest theme and its references from the SWC project. This is a first step towards deprecating the lightest & darkest themes and its files from the project. We will be continuing with only light and dark variants of spectrum and express and spectrum-2 systems.
Related issue(s)
Motivation and context
How has this been tested?
- [ ] Test case 1
- Go here
- Do this
- [ ] Test case 2
- Go here
- Do this
Screenshots (if appropriate)
Types of changes
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)
Checklist
- [ ] I have signed the Adobe Open Source CLA.
- [ ] My code follows the code style of this project.
- [ ] If my change required a change to the documentation, I have updated the documentation in this pull request.
- [ ] I have read the CONTRIBUTING document.
- [ ] I have added tests to cover my changes.
- [ ] All new and existing tests passed.
- [ ] I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.
Branch preview
Visual regression test results
When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
- High Contrast Mode | Medium | LTR
- Classic | Light | Medium | LTR
- Classic | Light | Medium | RTL
- Classic | Light | Large | LTR
- Classic | Light | Large | RTL
- Classic | Dark | Medium | LTR
- Classic | Dark | Medium | RTL
- Classic | Dark | Large | LTR
- Classic | Dark | Large | RTL
- Classic | Darkest | Medium | LTR
- Classic | Darkest | Medium | RTL
- Classic | Darkest | Large | LTR
- Classic | Darkest | Large | RTL
- Express | Light | Medium | LTR
- Express | Light | Medium | RTL
- Express | Light | Large | LTR
- Express | Light | Large | RTL
- Express | Dark | Medium | LTR
- Express | Dark | Medium | RTL
- Express | Dark | Large | LTR
- Express | Dark | Large | RTL
- Express | Darkest | Medium | LTR
- Express | Darkest | Medium | RTL
- Express | Darkest | Large | LTR
- Express | Darkest | Large | RTL
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Lighthouse scores
| Category | Latest (report) | Main (report) | Branch (report) |
|---|---|---|---|
| Performance | 0.97 | 0.97 | 0.98 |
| Accessibility | 1 | 1 | 1 |
| Best Practices | 1 | 1 | 1 |
| SEO | 1 | 0.92 | 0.92 |
| PWA | 1 | 1 | 1 |
What is this?
Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.
Transfer Size
| Category | Latest | Main | Branch |
|---|---|---|---|
| Total | 242.092 kB | 228.667 kB | 228.653 kB 🏆 |
| Scripts | 60.754 kB | 54.635 kB | 54.549 kB 🏆 |
| Stylesheet | 48.808 kB | 42.147 kB 🏆 | 42.22 kB |
| Document | 5.818 kB | 5.173 kB | 5.172 kB 🏆 |
| Third Party | 126.712 kB | 126.712 kB | 126.712 kB |
Request Count
| Category | Latest | Main | Branch |
|---|---|---|---|
| Total | 43 | 43 | 43 |
| Scripts | 35 | 35 | 35 |
| Stylesheet | 5 | 5 | 5 |
| Document | 1 | 1 | 1 |
| Third Party | 2 | 2 | 2 |
Tachometer results
Chrome
action-bar permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 446 kB | 67.94ms - 69.86ms | - | unsure 🔍 -4% - +1% -2.50ms - +0.73ms |
| branch | 437 kB | 68.49ms - 71.09ms | unsure 🔍 -1% - +4% -0.73ms - +2.50ms |
- |
action-menu permalink
test-basic
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 607 kB | 161.35ms - 166.37ms | - | unsure 🔍 -2% - +2% -2.71ms - +3.37ms |
| branch | 599 kB | 161.81ms - 165.25ms | unsure 🔍 -2% - +2% -3.37ms - +2.71ms |
- |
card permalink
test-basic
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 465 kB | 58.22ms - 59.08ms | - | unsure 🔍 -1% - +1% -0.69ms - +0.46ms |
| branch | 456 kB | 58.39ms - 59.15ms | unsure 🔍 -1% - +1% -0.46ms - +0.69ms |
- |
combobox permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 668 kB | 35.62ms - 36.03ms | - | unsure 🔍 -2% - +1% -0.73ms - +0.27ms |
| branch | 659 kB | 35.60ms - 36.52ms | unsure 🔍 -1% - +2% -0.27ms - +0.73ms |
- |
light-dom-test permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 668 kB | 397.21ms - 403.86ms | - | unsure 🔍 -1% - +2% -3.51ms - +6.40ms |
| branch | 660 kB | 395.41ms - 402.77ms | unsure 🔍 -2% - +1% -6.40ms - +3.51ms |
- |
illustrated-message permalink
test-basic
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 367 kB | 30.31ms - 30.51ms | - | faster ✔ 1% - 2% 0.16ms - 0.53ms |
| branch | 358 kB | 30.60ms - 30.92ms | slower ❌ 1% - 2% 0.16ms - 0.53ms |
- |
menu permalink
test-basic
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 437 kB | 203.52ms - 207.74ms | - | unsure 🔍 -1% - +1% -2.43ms - +3.07ms |
| branch | 428 kB | 203.54ms - 207.08ms | unsure 🔍 -1% - +1% -3.07ms - +2.43ms |
- |
overlay permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 642 kB | 459.44ms - 463.13ms | - | unsure 🔍 -0% - +1% -1.49ms - +3.39ms |
| branch | 629 kB | 458.74ms - 461.94ms | unsure 🔍 -1% - +0% -3.39ms - +1.49ms |
- |
directive-test permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 729 kB | 34.79ms - 35.27ms | - | unsure 🔍 -2% - +0% -0.58ms - +0.14ms |
| branch | 740 kB | 34.98ms - 35.52ms | unsure 🔍 -0% - +2% -0.14ms - +0.58ms |
- |
element-test permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 720 kB | 345.19ms - 348.47ms | - | unsure 🔍 -1% - +1% -1.77ms - +3.16ms |
| branch | 711 kB | 344.30ms - 347.97ms | unsure 🔍 -1% - +1% -3.16ms - +1.77ms |
- |
lazy-test permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 720 kB | 51.15ms - 52.07ms | - | unsure 🔍 -2% - +1% -1.03ms - +0.43ms |
| branch | 712 kB | 51.34ms - 52.48ms | unsure 🔍 -1% - +2% -0.43ms - +1.03ms |
- |
picker permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 473 kB | 568.65ms - 577.14ms | - | unsure 🔍 -2% - +1% -8.68ms - +3.55ms |
| branch | 465 kB | 571.06ms - 579.87ms | unsure 🔍 -1% - +2% -3.55ms - +8.68ms |
- |
popover permalink
test-basic
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 345 kB | 20.20ms - 20.43ms | - | unsure 🔍 -1% - +1% -0.18ms - +0.11ms |
| branch | 336 kB | 20.26ms - 20.43ms | unsure 🔍 -1% - +1% -0.11ms - +0.18ms |
- |
slider permalink
test-basic
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 441 kB | 103.34ms - 105.05ms | - | unsure 🔍 -1% - +1% -1.29ms - +1.17ms |
| branch | 432 kB | 103.37ms - 105.14ms | unsure 🔍 -1% - +1% -1.17ms - +1.29ms |
- |
split-button permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 680 kB | 1865.28ms - 1867.44ms | - | unsure 🔍 -0% - +0% -2.03ms - +1.21ms |
| branch | 673 kB | 1865.56ms - 1867.98ms | unsure 🔍 -0% - +0% -1.21ms - +2.03ms |
- |
tooltip permalink
test-basic
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 613 kB | 59.43ms - 60.74ms | - | unsure 🔍 -2% - +1% -1.18ms - +0.57ms |
| branch | 605 kB | 59.81ms - 60.97ms | unsure 🔍 -1% - +2% -0.57ms - +1.18ms |
- |
test-directive permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 593 kB | 33.43ms - 34.08ms | - | unsure 🔍 -2% - +1% -0.70ms - +0.26ms |
| branch | 585 kB | 33.62ms - 34.33ms | unsure 🔍 -1% - +2% -0.26ms - +0.70ms |
- |
Firefox
action-bar permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 446 kB | 136.86ms - 144.46ms | - | unsure 🔍 -4% - +4% -5.01ms - +5.81ms |
| branch | 437 kB | 136.40ms - 144.12ms | unsure 🔍 -4% - +4% -5.81ms - +5.01ms |
- |
action-menu permalink
test-basic
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 607 kB | 310.41ms - 318.83ms | - | unsure 🔍 -3% - +1% -9.91ms - +3.47ms |
| branch | 599 kB | 312.64ms - 323.04ms | unsure 🔍 -1% - +3% -3.47ms - +9.91ms |
- |
card permalink
test-basic
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 465 kB | 107.18ms - 114.70ms | - | unsure 🔍 -0% - +9% -0.20ms - +9.76ms |
| branch | 456 kB | 102.90ms - 109.42ms | unsure 🔍 -9% - +0% -9.76ms - +0.20ms |
- |
combobox permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 668 kB | 65.71ms - 70.45ms | - | slower ❌ 14% - 23% 8.27ms - 13.25ms |
| branch | 659 kB | 56.56ms - 58.08ms | faster ✔ 13% - 19% 8.27ms - 13.25ms |
- |
light-dom-test permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 668 kB | 696.56ms - 710.32ms | - | slower ❌ 2% - 6% 13.79ms - 38.77ms |
| branch | 660 kB | 666.74ms - 687.58ms | faster ✔ 2% - 5% 13.79ms - 38.77ms |
- |
illustrated-message permalink
test-basic
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 367 kB | 47.11ms - 51.33ms | - | unsure 🔍 -8% - +4% -4.16ms - +2.24ms |
| branch | 358 kB | 47.77ms - 52.59ms | unsure 🔍 -5% - +9% -2.24ms - +4.16ms |
- |
menu permalink
test-basic
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 437 kB | 382.23ms - 393.93ms | - | unsure 🔍 -1% - +3% -4.53ms - +10.33ms |
| branch | 428 kB | 380.60ms - 389.76ms | unsure 🔍 -3% - +1% -10.33ms - +4.53ms |
- |
overlay permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 726 kB | 685.02ms - 695.82ms | - | slower ❌ 1% - 4% 6.29ms - 28.75ms |
| branch | 718 kB | 663.05ms - 682.75ms | faster ✔ 1% - 4% 6.29ms - 28.75ms |
- |
directive-test permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 729 kB | 69.74ms - 70.62ms | - | unsure 🔍 -2% - +0% -1.68ms - +0.24ms |
| branch | 720 kB | 70.05ms - 71.75ms | unsure 🔍 -0% - +2% -0.24ms - +1.68ms |
- |
element-test permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 720 kB | 620.47ms - 629.29ms | - | slower ❌ 5% - 7% 31.15ms - 42.09ms |
| branch | 711 kB | 585.02ms - 591.50ms | faster ✔ 5% - 7% 31.15ms - 42.09ms |
- |
lazy-test permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 720 kB | 112.17ms - 116.79ms | - | slower ❌ 5% - 10% 5.13ms - 10.71ms |
| branch | 712 kB | 105.01ms - 108.11ms | faster ✔ 5% - 9% 5.13ms - 10.71ms |
- |
picker permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 473 kB | 981.30ms - 1007.50ms | - | unsure 🔍 -1% - +2% -5.00ms - +22.60ms |
| branch | 465 kB | 981.27ms - 989.93ms | unsure 🔍 -2% - +0% -22.60ms - +5.00ms |
- |
popover permalink
test-basic
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 345 kB | 38.36ms - 41.48ms | - | unsure 🔍 -8% - +4% -3.26ms - +1.70ms |
| branch | 336 kB | 38.77ms - 42.63ms | unsure 🔍 -4% - +8% -1.70ms - +3.26ms |
- |
slider permalink
test-basic
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 441 kB | 195.65ms - 204.15ms | - | unsure 🔍 -2% - +3% -3.61ms - +6.29ms |
| branch | 432 kB | 196.02ms - 201.10ms | unsure 🔍 -3% - +2% -6.29ms - +3.61ms |
- |
split-button permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 680 kB | 1596.75ms - 1603.85ms | - | unsure 🔍 -1% - +0% -9.78ms - +1.34ms |
| branch | 673 kB | 1600.25ms - 1608.79ms | unsure 🔍 -0% - +1% -1.34ms - +9.78ms |
- |
tooltip permalink
test-basic
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 613 kB | 205.63ms - 212.29ms | - | unsure 🔍 -1% - +4% -2.03ms - +7.67ms |
| branch | 605 kB | 202.62ms - 209.66ms | unsure 🔍 -4% - +1% -7.67ms - +2.03ms |
- |
test-directive permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 593 kB | 71.20ms - 74.80ms | - | faster ✔ 13% - 21% 11.01ms - 18.47ms |
| branch | 585 kB | 84.47ms - 91.01ms | slower ❌ 15% - 26% 11.01ms - 18.47ms |
- |