spectrum-web-components icon indicating copy to clipboard operation
spectrum-web-components copied to clipboard

Update lit to v3

Open damooo opened this issue 2 years ago • 3 comments
trafficstars

Code of conduct

  • [X] I agree to follow this project's code of conduct.

Impacted component(s)

All

Description of the requested feature

Lit is updated to v3. There are not many breaking changes. It will be great if swc update the dependency too. Otherwise bundler seems including both versions, and types are incompatible when used along with new lit versions, and other ecosystem components.

Mockups or screenshots

No response

Implementation notes or ideas

No response

damooo avatar Nov 06 '23 09:11 damooo

We are tracking this in #3209, but it will likely still be a little while yet before we are able to release fully [email protected] versions of the library. Depending on install order and package manager configurations, there should be no issue in using our components in a [email protected] application. You will need to have both versions in your build, but in terms of client side libraries is quite a small price to pay. I can say that you won't be able to force the next version (via resolutions or overrides) without issue today, but maybe there's an interim step that we could do to unlock that in the time being.

Westbrook avatar Nov 06 '23 13:11 Westbrook

I can say that you won't be able to force the next version (via resolutions or overrides) without issue today, but maybe there's an interim step that we could do to unlock that in the time being.

As update being already worked upon, it is not an issue to include both versions now. And also no particular other urgent reason to override. swc seems re-exporting lit functionalities. I would be importing them, as we are anyway using SpectrumElement as baseclass.

damooo avatar Nov 06 '23 13:11 damooo

It shouldn't be an issue to include both versions.

In face, if you're always importing through SWC then you'll always get v2, which means you wouldn't really be using two versions!

Westbrook avatar Nov 06 '23 13:11 Westbrook