spectrum-web-components icon indicating copy to clipboard operation
spectrum-web-components copied to clipboard

[Bug]: asset of types file and folder should use High Contrast mode colours

Open jnurthen opened this issue 2 years ago • 4 comments

Code of conduct

  • [X] I agree to follow this project's code of conduct.

Impacted component(s)

sp-asset

Expected behavior

When running in high contrast mode the file and folder asset types should use the high contrast mode colours so they are always visible no matter the theme chosen

Actual behavior

They use --spectrum-asset-file-background-color and do not follow high contrast mode

Screenshots

No response

What browsers are you seeing the problem in?

Chrome, Microsoft Edge

How can we reproduce this issue?

  1. Go to https://opensource.adobe.com/spectrum-web-components/components/asset/
  2. Turn on high contrast mode (either in dev tools or at Windows OS level)
  3. Scroll to the file/folder images
  4. Note they are a grey not one of the high contrast colors

Sample code that illustrates the problem

No response

Logs taken while reproducing problem

No response

jnurthen avatar Jun 27 '23 20:06 jnurthen

@pfulton is Asset on the to do list for Core Tokens? Will this work be included in that update?

Westbrook avatar Jun 27 '23 20:06 Westbrook

@Westbrook I'd been told that it was going to be deprecated, but I will need to double-check that with design folks. I'll get back to you ASAP!

pfulton avatar Jun 27 '23 21:06 pfulton

@Rajdeepc This seems like it's a deprecated feature, can you look into what we can do with it or if we should close?

jnjosh avatar Nov 16 '23 14:11 jnjosh

We discussed this and, while Spectrum CSS will be deprecating this component, we will fix this issue before deprecating. We're tracking it in Jira via CSS-645

pfulton avatar Dec 01 '23 19:12 pfulton

Closed by https://github.com/adobe/spectrum-css/pull/2369

Rajdeepc avatar Apr 23 '24 07:04 Rajdeepc