spectrum-web-components icon indicating copy to clipboard operation
spectrum-web-components copied to clipboard

[TESTING, not for MERGE] refactor: leverage colorjs.io instead of tiny color

Open Westbrook opened this issue 2 years ago • 4 comments

Investigate leveraging colorjs.io.

  • what's the KB cost of the more "correct" color transformations
  • does this open the door for channel support more naturally in Color Slider
  • can we further simplify the relationship between the Color Controller and a UI leveraging

fixes #3635

Westbrook avatar Dec 06 '22 14:12 Westbrook

Tachometer results

Chrome

accordion permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 415 kB 137.62ms - 140.26ms - unsure 🔍
-2% - +2%
-2.81ms - +2.93ms
branch 406 kB 136.33ms - 141.43ms unsure 🔍
-2% - +2%
-2.93ms - +2.81ms
-

action-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 483 kB 72.05ms - 76.05ms - unsure 🔍
-1% - +5%
-0.92ms - +3.84ms
branch 474 kB 71.29ms - 73.88ms unsure 🔍
-5% - +1%
-3.84ms - +0.92ms
-

action-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 535 kB 66.86ms - 68.21ms - unsure 🔍
-1% - +2%
-0.81ms - +1.03ms
branch 526 kB 66.80ms - 68.05ms unsure 🔍
-2% - +1%
-1.03ms - +0.81ms
-

action-menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 644 kB 168.48ms - 172.37ms - unsure 🔍
-1% - +2%
-2.23ms - +3.58ms
branch 635 kB 167.59ms - 171.92ms unsure 🔍
-2% - +1%
-3.58ms - +2.23ms
-

coachmark permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 626 kB 117.92ms - 120.06ms - unsure 🔍
-3% - +0%
-3.02ms - +0.57ms
branch 617 kB 118.77ms - 121.66ms unsure 🔍
-0% - +3%
-0.57ms - +3.02ms
-

color-area permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 452 kB 133.94ms - 135.05ms - faster ✔
5% - 6%
6.80ms - 8.59ms
branch 553 kB 141.49ms - 142.89ms slower ❌
5% - 6%
6.80ms - 8.59ms
-

color-slider permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 454 kB 113.01ms - 113.94ms - faster ✔
3% - 4%
3.58ms - 5.01ms
branch 554 kB 117.23ms - 118.32ms slower ❌
3% - 4%
3.58ms - 5.01ms
-

color-wheel permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 455 kB 113.24ms - 114.98ms - faster ✔
3% - 5%
3.51ms - 5.68ms
branch 555 kB 118.05ms - 119.36ms slower ❌
3% - 5%
3.51ms - 5.68ms
-

combobox permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 704 kB 38.65ms - 39.19ms - unsure 🔍
-2% - +1%
-0.77ms - +0.28ms
branch 696 kB 38.72ms - 39.61ms unsure 🔍
-1% - +2%
-0.28ms - +0.77ms
-

light-dom-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 705 kB 419.00ms - 426.16ms - unsure 🔍
-2% - +1%
-6.48ms - +5.47ms
branch 696 kB 418.30ms - 427.87ms unsure 🔍
-1% - +2%
-5.47ms - +6.48ms
-

field-label permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 390 kB 25.62ms - 26.55ms - unsure 🔍
-2% - +2%
-0.39ms - +0.63ms
branch 381 kB 25.76ms - 26.17ms unsure 🔍
-2% - +1%
-0.63ms - +0.39ms
-

grid permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 459 kB 37.41ms - 38.08ms - slower ❌
2% - 4%
0.56ms - 1.47ms
branch 431 kB 36.42ms - 37.03ms faster ✔
2% - 4%
0.56ms - 1.47ms
-

menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 473 kB 221.24ms - 225.17ms - unsure 🔍
-1% - +2%
-1.81ms - +4.19ms
branch 465 kB 219.74ms - 224.28ms unsure 🔍
-2% - +1%
-4.19ms - +1.81ms
-

meter permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 405 kB 57.70ms - 58.35ms - unsure 🔍
-1% - +1%
-0.51ms - +0.41ms
branch 397 kB 57.74ms - 58.41ms unsure 🔍
-1% - +1%
-0.41ms - +0.51ms
-

number-field permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 521 kB 95.93ms - 97.94ms - unsure 🔍
-1% - +2%
-1.24ms - +1.62ms
branch 513 kB 95.73ms - 97.76ms unsure 🔍
-2% - +1%
-1.62ms - +1.24ms
-

overlay permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 684 kB 472.11ms - 475.49ms - unsure 🔍
-0% - +1%
-2.32ms - +2.80ms
branch 666 kB 471.64ms - 475.48ms unsure 🔍
-1% - +0%
-2.80ms - +2.32ms
-

directive-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 775 kB 36.54ms - 37.06ms - unsure 🔍
-2% - +0%
-0.70ms - +0.08ms
branch 774 kB 36.82ms - 37.39ms unsure 🔍
-0% - +2%
-0.08ms - +0.70ms
-

element-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 756 kB 351.35ms - 354.82ms - unsure 🔍
-2% - +0%
-5.92ms - +0.80ms
branch 748 kB 352.77ms - 358.52ms unsure 🔍
-0% - +2%
-0.80ms - +5.92ms
-

lazy-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 757 kB 53.95ms - 55.34ms - unsure 🔍
-1% - +2%
-0.80ms - +1.16ms
branch 749 kB 53.77ms - 55.15ms unsure 🔍
-2% - +1%
-1.16ms - +0.80ms
-

picker permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 510 kB 577.36ms - 587.11ms - unsure 🔍
-2% - +1%
-10.07ms - +4.23ms
branch 501 kB 579.93ms - 590.39ms unsure 🔍
-1% - +2%
-4.23ms - +10.07ms
-

popover permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 382 kB 21.79ms - 21.97ms - unsure 🔍
-1% - +0%
-0.28ms - +0.08ms
branch 373 kB 21.83ms - 22.14ms unsure 🔍
-0% - +1%
-0.08ms - +0.28ms
-

progress-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 406 kB 46.59ms - 47.28ms - unsure 🔍
-2% - +0%
-0.83ms - +0.21ms
branch 397 kB 46.86ms - 47.63ms unsure 🔍
-0% - +2%
-0.21ms - +0.83ms
-

radio permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 405 kB 60.74ms - 62.08ms - unsure 🔍
-3% - +1%
-1.78ms - +0.78ms
branch 396 kB 60.82ms - 63.00ms unsure 🔍
-1% - +3%
-0.78ms - +1.78ms
-

sidenav permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 427 kB 275.82ms - 280.22ms - unsure 🔍
-2% - +0%
-5.55ms - +1.08ms
branch 418 kB 277.77ms - 282.74ms unsure 🔍
-0% - +2%
-1.08ms - +5.55ms
-

slider permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 477 kB 107.03ms - 108.80ms - unsure 🔍
-2% - +1%
-2.08ms - +0.70ms
branch 469 kB 107.54ms - 109.68ms unsure 🔍
-1% - +2%
-0.70ms - +2.08ms
-

split-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 717 kB 1867.37ms - 1870.12ms - unsure 🔍
-0% - +0%
-1.98ms - +2.00ms
branch 709 kB 1867.30ms - 1870.17ms unsure 🔍
-0% - +0%
-2.00ms - +1.98ms
-

swatch permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 406 kB 23.88ms - 25.02ms - unsure 🔍
-2% - +3%
-0.43ms - +0.76ms
branch 398 kB 24.10ms - 24.47ms unsure 🔍
-3% - +2%
-0.76ms - +0.43ms
-

tabs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 423 kB 107.34ms - 109.47ms - unsure 🔍
-2% - +1%
-1.65ms - +1.21ms
branch 414 kB 107.67ms - 109.58ms unsure 🔍
-1% - +2%
-1.21ms - +1.65ms
-

tags permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 449 kB 20.85ms - 21.80ms - unsure 🔍
-1% - +4%
-0.26ms - +0.76ms
branch 440 kB 20.90ms - 21.25ms unsure 🔍
-4% - +1%
-0.76ms - +0.26ms
-

tooltip permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 650 kB 61.69ms - 62.62ms - faster ✔
0% - 3%
0.05ms - 1.89ms
branch 642 kB 62.33ms - 63.91ms slower ❌
0% - 3%
0.05ms - 1.89ms
-

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 630 kB 35.84ms - 36.40ms - unsure 🔍
-0% - +2%
-0.13ms - +0.81ms
branch 622 kB 35.40ms - 36.16ms unsure 🔍
-2% - +0%
-0.81ms - +0.13ms
-

top-nav permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 429 kB 77.72ms - 79.27ms - unsure 🔍
-1% - +2%
-0.53ms - +1.59ms
branch 420 kB 77.24ms - 78.69ms unsure 🔍
-2% - +1%
-1.59ms - +0.53ms
-

tray permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 522 kB 96.26ms - 97.26ms - unsure 🔍
-1% - +1%
-0.70ms - +0.67ms
branch 513 kB 96.30ms - 97.24ms unsure 🔍
-1% - +1%
-0.67ms - +0.70ms
-
Firefox

accordion permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 415 kB 269.28ms - 281.64ms - unsure 🔍
-2% - +3%
-6.15ms - +8.99ms
branch 406 kB 269.67ms - 278.41ms unsure 🔍
-3% - +2%
-8.99ms - +6.15ms
-

action-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 483 kB 147.85ms - 156.11ms - unsure 🔍
-2% - +6%
-2.27ms - +8.71ms
branch 474 kB 145.14ms - 152.38ms unsure 🔍
-6% - +1%
-8.71ms - +2.27ms
-

action-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 535 kB 162.96ms - 170.52ms - unsure 🔍
-2% - +5%
-2.44ms - +8.52ms
branch 526 kB 159.74ms - 167.66ms unsure 🔍
-5% - +1%
-8.52ms - +2.44ms
-

action-menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 644 kB 324.01ms - 336.19ms - unsure 🔍
-3% - +3%
-8.63ms - +8.59ms
branch 635 kB 324.03ms - 336.21ms unsure 🔍
-3% - +3%
-8.59ms - +8.63ms
-

coachmark permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 626 kB 394.46ms - 403.22ms - unsure 🔍
-0% - +3%
-0.86ms - +12.50ms
branch 617 kB 387.97ms - 398.07ms unsure 🔍
-3% - +0%
-12.50ms - +0.86ms
-

color-area permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 452 kB 217.71ms - 224.05ms - faster ✔
5% - 10%
12.57ms - 23.27ms
branch 553 kB 234.49ms - 243.11ms slower ❌
6% - 11%
12.57ms - 23.27ms
-

color-slider permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 454 kB 208.76ms - 215.28ms - faster ✔
1% - 6%
3.19ms - 12.45ms
branch 554 kB 216.55ms - 223.13ms slower ❌
1% - 6%
3.19ms - 12.45ms
-

color-wheel permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 455 kB 196.90ms - 204.62ms - faster ✔
2% - 7%
4.12ms - 15.60ms
branch 555 kB 206.37ms - 214.87ms slower ❌
2% - 8%
4.12ms - 15.60ms
-

combobox permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 704 kB 66.56ms - 72.72ms - slower ❌
6% - 17%
3.89ms - 10.39ms
branch 696 kB 61.48ms - 63.52ms faster ✔
6% - 14%
3.89ms - 10.39ms
-

light-dom-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 705 kB 716.19ms - 743.37ms - slower ❌
4% - 8%
24.90ms - 53.90ms
branch 696 kB 685.32ms - 695.44ms faster ✔
4% - 7%
24.90ms - 53.90ms
-

field-label permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 390 kB 57.21ms - 61.83ms - unsure 🔍
-7% - +5%
-4.01ms - +3.09ms
branch 381 kB 57.29ms - 62.67ms unsure 🔍
-5% - +7%
-3.09ms - +4.01ms
-

grid permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 459 kB 86.30ms - 91.10ms - unsure 🔍
-1% - +7%
-0.58ms - +6.10ms
branch 431 kB 83.61ms - 88.27ms unsure 🔍
-7% - +1%
-6.10ms - +0.58ms
-

menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 473 kB 431.42ms - 444.66ms - unsure 🔍
-2% - +2%
-8.39ms - +8.55ms
branch 465 kB 432.67ms - 443.25ms unsure 🔍
-2% - +2%
-8.55ms - +8.39ms
-

meter permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 405 kB 98.49ms - 103.39ms - unsure 🔍
-2% - +5%
-1.81ms - +4.53ms
branch 397 kB 97.56ms - 101.60ms unsure 🔍
-4% - +2%
-4.53ms - +1.81ms
-

number-field permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 521 kB 200.31ms - 211.69ms - unsure 🔍
-4% - +3%
-8.24ms - +6.52ms
branch 513 kB 202.16ms - 211.56ms unsure 🔍
-3% - +4%
-6.52ms - +8.24ms
-

overlay permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 763 kB 714.81ms - 727.99ms - slower ❌
1% - 4%
5.97ms - 30.75ms
branch 755 kB 692.55ms - 713.53ms faster ✔
1% - 4%
5.97ms - 30.75ms
-

directive-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 765 kB 72.56ms - 73.76ms - unsure 🔍
-3% - +0%
-2.48ms - +0.20ms
branch 757 kB 73.10ms - 75.50ms unsure 🔍
-0% - +3%
-0.20ms - +2.48ms
-

element-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 756 kB 639.50ms - 650.86ms - slower ❌
5% - 8%
31.96ms - 46.92ms
branch 748 kB 600.87ms - 610.61ms faster ✔
5% - 7%
31.96ms - 46.92ms
-

lazy-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 757 kB 119.76ms - 126.40ms - slower ❌
8% - 15%
9.09ms - 16.15ms
branch 749 kB 109.24ms - 111.68ms faster ✔
8% - 13%
9.09ms - 16.15ms
-

picker permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 510 kB 1023.70ms - 1037.34ms - unsure 🔍
-2% - +1%
-21.01ms - +12.17ms
branch 501 kB 1019.81ms - 1050.07ms unsure 🔍
-1% - +2%
-12.17ms - +21.01ms
-

popover permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 382 kB 42.19ms - 44.85ms - unsure 🔍
-7% - +3%
-3.11ms - +1.27ms
branch 373 kB 42.70ms - 46.18ms unsure 🔍
-3% - +7%
-1.27ms - +3.11ms
-

progress-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 406 kB 82.07ms - 88.33ms - unsure 🔍
-3% - +6%
-2.79ms - +4.75ms
branch 397 kB 82.13ms - 86.31ms unsure 🔍
-6% - +3%
-4.75ms - +2.79ms
-

radio permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 405 kB 126.73ms - 132.95ms - unsure 🔍
-4% - +3%
-5.85ms - +3.73ms
branch 396 kB 127.26ms - 134.54ms unsure 🔍
-3% - +5%
-3.73ms - +5.85ms
-

sidenav permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 427 kB 516.83ms - 532.45ms - unsure 🔍
-2% - +2%
-11.95ms - +8.43ms
branch 418 kB 519.85ms - 532.95ms unsure 🔍
-2% - +2%
-8.43ms - +11.95ms
-

slider permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 477 kB 205.52ms - 214.04ms - unsure 🔍
-2% - +4%
-3.12ms - +7.44ms
branch 469 kB 204.50ms - 210.74ms unsure 🔍
-4% - +1%
-7.44ms - +3.12ms
-

split-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 717 kB 1652.36ms - 1659.96ms - unsure 🔍
-0% - +0%
-7.97ms - +2.85ms
branch 709 kB 1654.87ms - 1662.57ms unsure 🔍
-0% - +0%
-2.85ms - +7.97ms
-

swatch permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 406 kB 60.39ms - 64.53ms - unsure 🔍
-6% - +4%
-3.97ms - +2.69ms
branch 398 kB 60.50ms - 65.70ms unsure 🔍
-4% - +6%
-2.69ms - +3.97ms
-

tabs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 423 kB 208.38ms - 215.98ms - unsure 🔍
-2% - +3%
-3.84ms - +6.56ms
branch 414 kB 207.26ms - 214.38ms unsure 🔍
-3% - +2%
-6.56ms - +3.84ms
-

tags permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 449 kB 43.72ms - 47.12ms - unsure 🔍
-3% - +8%
-1.47ms - +3.39ms
branch 440 kB 42.72ms - 46.20ms unsure 🔍
-7% - +3%
-3.39ms - +1.47ms
-

tooltip permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 650 kB 210.57ms - 218.55ms - unsure 🔍
-2% - +3%
-4.40ms - +7.12ms
branch 642 kB 209.05ms - 217.35ms unsure 🔍
-3% - +2%
-7.12ms - +4.40ms
-

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 630 kB 72.24ms - 74.00ms - faster ✔
22% - 26%
20.90ms - 25.18ms
branch 622 kB 94.21ms - 98.11ms slower ❌
28% - 35%
20.90ms - 25.18ms
-

top-nav permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 429 kB 151.21ms - 160.07ms - unsure 🔍
-4% - +3%
-7.07ms - +4.03ms
branch 420 kB 153.82ms - 160.50ms unsure 🔍
-3% - +5%
-4.03ms - +7.07ms
-

tray permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 522 kB 173.04ms - 180.24ms - unsure 🔍
-3% - +3%
-5.02ms - +4.82ms
branch 513 kB 173.38ms - 180.10ms unsure 🔍
-3% - +3%
-4.82ms - +5.02ms
-

github-actions[bot] avatar Dec 06 '22 15:12 github-actions[bot]

https://github.com/adobe/spectrum-web-components/issues/3652

najikahalsema avatar Sep 19 '23 15:09 najikahalsema

Lighthouse scores

Category Latest (report) Main (report) Branch (report)
Performance 0.97 0.98 0.97
Accessibility 1 1 1
Best Practices 1 1 1
SEO 1 0.92 0.92
PWA 1 1 1
What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category Latest Main Branch
Total 242.276 kB 228.865 kB 227.467 kB 🏆
Scripts 61.231 kB 54.595 kB 54.28 kB 🏆
Stylesheet 48.513 kB 42.382 kB 41.329 kB 🏆
Document 5.82 kB 5.176 kB 5.146 kB 🏆
Third Party 126.712 kB 126.712 kB 126.712 kB

Request Count

Category Latest Main Branch
Total 43 43 43
Scripts 35 35 35
Stylesheet 5 5 5
Document 1 1 1
Third Party 2 2 2

github-actions[bot] avatar Mar 05 '24 00:03 github-actions[bot]