spectrum-web-components
spectrum-web-components copied to clipboard
Published
20 hours ago •
adobe
adobe
refactor(action-group): use core tokens
trafficstars
Adds a beta version of the new ActionGroup component.
Uses beta release, hold for full release.
Related issue(s)
Motivation and context
How has this been tested?
- [ ] Test case 1
- Go here
- Do this
- [ ] Test case 2
- Go here
- Do this
Screenshots (if appropriate)
Types of changes
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)
Checklist
- [ ] I have signed the Adobe Open Source CLA.
- [ ] My code follows the code style of this project.
- [ ] If my change required a change to the documentation, I have updated the documentation in this pull request.
- [ ] I have read the CONTRIBUTING document.
- [ ] I have added tests to cover my changes.
- [ ] All new and existing tests passed.
- [ ] I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.
Branch Preview
Visual regression test results
When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
- High Contrast Mode | Medium | LTR
- Classic | Lightest | Medium | LTR
- Classic | Lightest | Medium | RTL
- Classic | Lightest | Large | LTR
- Classic | Lightest | Large | RTL
- Classic | Light | Medium | LTR
- Classic | Light | Medium | RTL
- Classic | Light | Large | LTR
- Classic | Light | Large | RTL
- Classic | Dark | Medium | LTR
- Classic | Dark | Medium | RTL
- Classic | Dark | Large | LTR
- Classic | Dark | Large | RTL
- Classic | Darkest | Medium | LTR
- Classic | Darkest | Medium | RTL
- Classic | Darkest | Large | LTR
- Classic | Darkest | Large | RTL
- Express | Lightest | Medium | LTR
- Express | Lightest | Medium | RTL
- Express | Lightest | Large | LTR
- Express | Lightest | Large | RTL
- Express | Light | Medium | LTR
- Express | Light | Medium | RTL
- Express | Light | Large | LTR
- Express | Light | Large | RTL
- Express | Dark | Medium | LTR
- Express | Dark | Medium | RTL
- Express | Dark | Large | LTR
- Express | Dark | Large | RTL
- Express | Darkest | Medium | LTR
- Express | Darkest | Medium | RTL
- Express | Darkest | Large | LTR
- Express | Darkest | Large | RTL
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Tachometer results
Chrome
action-bar permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 244 kB | 33.94ms - 34.27ms | - | unsure 🔍 -1% - +1% -0.30ms - +0.26ms |
| branch | 244 kB | 33.91ms - 34.34ms | unsure 🔍 -1% - +1% -0.26ms - +0.30ms |
- |
action-button permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 412 kB | 40.29ms - 40.79ms | - | faster ✔ 26% - 28% 14.43ms - 16.09ms |
| branch | 412 kB | 55.01ms - 56.59ms | slower ❌ 36% - 40% 14.43ms - 16.09ms |
- |
action-group permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 438 kB | 108.83ms - 110.37ms | - | slower ❌ 1% - 4% 1.46ms - 3.74ms |
| branch | 434 kB | 106.16ms - 107.84ms | faster ✔ 1% - 3% 1.46ms - 3.74ms |
- |
action-menu permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 608 kB | 202.45ms - 207.23ms | - | unsure 🔍 -1% - +2% -2.25ms - +4.12ms |
| branch | 608 kB | 201.80ms - 206.01ms | unsure 🔍 -2% - +1% -4.12ms - +2.25ms |
- |
card permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 391 kB | 84.13ms - 86.16ms | - | unsure 🔍 -2% - +2% -1.62ms - +1.41ms |
| branch | 391 kB | 84.12ms - 86.37ms | unsure 🔍 -2% - +2% -1.41ms - +1.62ms |
- |
illustrated-message permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 293 kB | 41.74ms - 42.46ms | - | unsure 🔍 -1% - +2% -0.22ms - +0.77ms |
| branch | 293 kB | 41.48ms - 42.16ms | unsure 🔍 -2% - +1% -0.77ms - +0.22ms |
- |
menu permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 309 kB | 233.82ms - 238.26ms | - | unsure 🔍 -1% - +1% -2.76ms - +2.87ms |
| branch | 309 kB | 234.25ms - 237.72ms | unsure 🔍 -1% - +1% -2.87ms - +2.76ms |
- |
number-field permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 505 kB | 166.12ms - 169.32ms | - | unsure 🔍 -0% - +2% -0.13ms - +3.97ms |
| branch | 505 kB | 164.52ms - 167.08ms | unsure 🔍 -2% - +0% -3.97ms - +0.13ms |
- |
overlay permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 347 kB | 72.09ms - 73.34ms | - | unsure 🔍 -2% - +1% -1.11ms - +0.71ms |
| branch | 347 kB | 72.25ms - 73.58ms | unsure 🔍 -1% - +2% -0.71ms - +1.11ms |
- |
picker permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 453 kB | 650.69ms - 671.87ms | - | unsure 🔍 -2% - +2% -13.13ms - +15.25ms |
| branch | 453 kB | 650.78ms - 669.67ms | unsure 🔍 -2% - +2% -15.25ms - +13.13ms |
- |
popover permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 241 kB | 31.11ms - 31.78ms | - | unsure 🔍 -0% - +3% -0.04ms - +0.81ms |
| branch | 240 kB | 30.80ms - 31.33ms | unsure 🔍 -3% - +0% -0.81ms - +0.04ms |
- |
slider permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 341 kB | 136.93ms - 139.76ms | - | unsure 🔍 -2% - +1% -2.30ms - +1.54ms |
| branch | 341 kB | 137.43ms - 140.03ms | unsure 🔍 -1% - +2% -1.54ms - +2.30ms |
- |
split-button permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 546 kB | 1951.67ms - 1955.08ms | - | unsure 🔍 -0% - +0% -3.15ms - +1.70ms |
| branch | 546 kB | 1952.38ms - 1955.83ms | unsure 🔍 -0% - +0% -1.70ms - +3.15ms |
- |
tooltip permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 247 kB | 31.29ms - 31.88ms | - | unsure 🔍 -2% - +1% -0.67ms - +0.32ms |
| branch | 247 kB | 31.37ms - 32.16ms | unsure 🔍 -1% - +2% -0.32ms - +0.67ms |
- |
Firefox
action-bar permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 244 kB | 87.58ms - 92.90ms | - | unsure 🔍 -8% - +3% -7.15ms - +2.87ms |
| branch | 244 kB | 88.13ms - 96.63ms | unsure 🔍 -3% - +8% -2.87ms - +7.15ms |
- |
action-button permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 412 kB | 102.92ms - 112.40ms | - | slower ❌ 2% - 13% 1.74ms - 12.90ms |
| branch | 412 kB | 97.39ms - 103.29ms | faster ✔ 2% - 12% 1.74ms - 12.90ms |
- |
action-group permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 438 kB | 282.33ms - 293.87ms | - | unsure 🔍 -4% - +1% -12.78ms - +3.78ms |
| branch | 434 kB | 286.66ms - 298.54ms | unsure 🔍 -1% - +4% -3.78ms - +12.78ms |
- |
action-menu permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 608 kB | 354.51ms - 368.93ms | - | unsure 🔍 -2% - +3% -8.74ms - +9.94ms |
| branch | 608 kB | 355.19ms - 367.05ms | unsure 🔍 -3% - +2% -9.94ms - +8.74ms |
- |
card permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 391 kB | 147.47ms - 157.13ms | - | unsure 🔍 -2% - +6% -2.51ms - +8.47ms |
| branch | 391 kB | 146.71ms - 151.93ms | unsure 🔍 -6% - +2% -8.47ms - +2.51ms |
- |
illustrated-message permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 293 kB | 73.63ms - 78.05ms | - | faster ✔ 10% - 22% 8.64ms - 20.96ms |
| branch | 293 kB | 84.89ms - 96.39ms | slower ❌ 11% - 28% 8.64ms - 20.96ms |
- |
menu permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 309 kB | 486.27ms - 495.33ms | - | unsure 🔍 -2% - +1% -9.25ms - +3.81ms |
| branch | 309 kB | 488.81ms - 498.23ms | unsure 🔍 -1% - +2% -3.81ms - +9.25ms |
- |
number-field permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 505 kB | 368.62ms - 375.54ms | - | unsure 🔍 -3% - +0% -10.78ms - +1.14ms |
| branch | 505 kB | 372.04ms - 381.76ms | unsure 🔍 -0% - +3% -1.14ms - +10.78ms |
- |
overlay permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 347 kB | 150.02ms - 161.62ms | - | unsure 🔍 -4% - +6% -6.83ms - +8.51ms |
| branch | 347 kB | 149.96ms - 160.00ms | unsure 🔍 -5% - +4% -8.51ms - +6.83ms |
- |
picker permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 453 kB | 952.06ms - 965.62ms | - | unsure 🔍 -2% - +0% -18.21ms - +0.05ms |
| branch | 453 kB | 961.80ms - 974.04ms | unsure 🔍 -0% - +2% -0.05ms - +18.21ms |
- |
popover permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 241 kB | 85.38ms - 102.06ms | - | unsure 🔍 -11% - +13% -10.62ms - +11.86ms |
| branch | 240 kB | 85.56ms - 100.64ms | unsure 🔍 -13% - +11% -11.86ms - +10.62ms |
- |
slider permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 341 kB | 308.82ms - 321.78ms | - | unsure 🔍 -4% - +1% -13.29ms - +4.49ms |
| branch | 341 kB | 313.62ms - 325.78ms | unsure 🔍 -1% - +4% -4.49ms - +13.29ms |
- |
split-button permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 546 kB | 2031.54ms - 2044.54ms | - | unsure 🔍 -1% - +0% -11.75ms - +8.39ms |
| branch | 546 kB | 2032.03ms - 2047.41ms | unsure 🔍 -0% - +1% -8.39ms - +11.75ms |
- |
tooltip permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 247 kB | 65.89ms - 69.23ms | - | faster ✔ 21% - 34% 17.36ms - 34.16ms |
| branch | 247 kB | 85.08ms - 101.56ms | slower ❌ 25% - 51% 17.36ms - 34.16ms |
- |
Looks like there are a few things related to margin that I need to check on with this one.
@Westbrook I think the missing thing here is the application of the t-shirt sizes. I tried taking a shot at applying them, but I think I'm missing something. The component doesn't actually seem to be applying the styles for a given size. Any thoughts?
First, looks like you've haven't run yarn since you set up the t-shirt size support.
Second, is there a preview of what t-shirt sizing should open up here?
Third, could you add something like what @bernhard-adobe did here to document the t-shirt sizes in Storybook?
@Westbrook let me know if these new stories will suffice for now. Also, if I did anything silly, let me know!
Also, I just graduated this component from beta over in the CSS repo. If you'd like me to switch to that release, let me know and I can make that adjustment!