spectrum-web-components icon indicating copy to clipboard operation
spectrum-web-components copied to clipboard

build: separate packages from tool when building TS

Open Westbrook opened this issue 2 years ago • 2 comments

Description

At the intersection of the esbuild output and the es-module-lexor processing various Storybook stories were being omitted from the UI. This alters the output of the *.stories.ts and *.test.ts files so that this won't happen anymore.

How has this been tested?

  • [ ] Test case 1
    1. Go here
    2. Compare to here

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)

Checklist

  • [x] I have signed the Adobe Open Source CLA.
  • [x] My code follows the code style of this project.
  • [x] If my change required a change to the documentation, I have updated the documentation in this pull request.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [x] All new and existing tests passed.

Westbrook avatar Aug 11 '22 11:08 Westbrook

Branch Preview

github-actions[bot] avatar Aug 11 '22 11:08 github-actions[bot]

Tachometer results

Currently, no packages are changed by this PR...

github-actions[bot] avatar Aug 11 '22 11:08 github-actions[bot]

Is the second link in your test case supposed to be missing the Switch stories? Just double checking to make sure I understand what you're trying to accomplish in this PR!

najikahalsema avatar Aug 16 '22 19:08 najikahalsema

@najikahalsema it is missing the Switch stories, and is not supposed to be missing them, which is what this PR fixes. So, it's a comparison between the code in main and the code in this PR.

Westbrook avatar Aug 16 '22 20:08 Westbrook