spectrum-web-components icon indicating copy to clipboard operation
spectrum-web-components copied to clipboard

Clarify end of work via API/code review guidelines

Open najikahalsema opened this issue 4 years ago • 1 comments

Identify and define guidelines for contributors to SWC to follow after completing work on their component. Some things to consider:

  • How do we know when a component is done?
  • Who is included in the review process?
  • What sorts of things are we looking for in a code review? How specific should we be?

najikahalsema avatar Feb 24 '21 22:02 najikahalsema

Test suite passes  
Build does not fail/regress  
Documentation  
API Documentation (inline JSDoc)  
Test coverage  
VRT  
Demo  
Published  
In production  

Thoughts?

Westbrook avatar May 10 '22 20:05 Westbrook

Sounds great to me. maybe it's redundant/self-explanatory, but a "reviewed" check as well?

najikahalsema avatar Oct 25 '22 18:10 najikahalsema

refs #1199

najikahalsema avatar Oct 25 '22 18:10 najikahalsema

duplicate

najikahalsema avatar Oct 25 '22 18:10 najikahalsema