spectrum-css icon indicating copy to clipboard operation
spectrum-css copied to clipboard

feat: menu contribution from rsp@v3

Open jianliao opened this issue 5 years ago • 10 comments

BLOCKED by design/DNA because naming things is hard

Description

Menu Component in RSP@v3

https://reactspectrum.blob.core.windows.net/reactspectrum/c9500ee4a9c5d87b188ddf12c93920da1f72305a/storybook/index.html?path=/story/menu--default-menu

The change broke a lot of things, need to polish very carefully.

How and where has this been tested?

  • How this was tested:
  • Browser(s) and OS(s) this was tested with:

Screenshots

To-do list

  • [ ] If my change impacts other components, I have tested to make sure they don't break.
  • [ ] If my change impacts documentation, I have updated the documentation accordingly.
  • [ ] I have read the CONTRIBUTING document.
  • [ ] This pull request is ready to merge.

jianliao avatar Mar 06 '20 21:03 jianliao

Test result: http://opensource.adobe.com/spectrum-css-vr-results/00a7baf-result-2020-03-06_22-00-11/html_report/

Dev Site: http://opensource.adobe.com/spectrum-css-vr-results/00a7baf-result-2020-03-06_22-00-11/dist/docs/

adobe-spectrum-bot avatar Mar 06 '20 22:03 adobe-spectrum-bot

Test result: http://opensource.adobe.com/spectrum-css-vr-results/e91f1cf-result-2020-03-10_00-14-32/html_report/

Dev Site: http://opensource.adobe.com/spectrum-css-vr-results/e91f1cf-result-2020-03-10_00-14-32/dist/docs/

adobe-spectrum-bot avatar Mar 10 '20 00:03 adobe-spectrum-bot

Test result: http://opensource.adobe.com/spectrum-css-vr-results/be54391-result-2020-03-15_02-34-27/html_report/

Dev Site: http://opensource.adobe.com/spectrum-css-vr-results/be54391-result-2020-03-15_02-34-27/dist/docs/

adobe-spectrum-bot avatar Mar 15 '20 02:03 adobe-spectrum-bot

Test result: http://opensource.adobe.com/spectrum-css-vr-results/a856ae3-result-2020-03-24_21-25-00/html_report/

Dev Site: http://opensource.adobe.com/spectrum-css-vr-results/a856ae3-result-2020-03-24_21-25-00/dist/docs/

adobe-spectrum-bot avatar Mar 24 '20 21:03 adobe-spectrum-bot

The change from RSP seems like starting to adapt the CSS grid layout system. Related to #644

jianliao avatar Mar 24 '20 21:03 jianliao

Test result: http://opensource.adobe.com/spectrum-css-vr-results/b2b38e3-result-2020-05-27_22-09-40/html_report/

Dev Site: http://opensource.adobe.com/spectrum-css-vr-results/b2b38e3-result-2020-05-27_22-09-40/dist/docs/

adobe-spectrum-bot avatar May 27 '20 22:05 adobe-spectrum-bot

Test result: http://opensource.adobe.com/spectrum-css-vr-results/53c2cc8-result-2020-05-28_15-59-30/html_report/

Dev Site: http://opensource.adobe.com/spectrum-css-vr-results/53c2cc8-result-2020-05-28_15-59-30/dist/docs/

adobe-spectrum-bot avatar May 28 '20 15:05 adobe-spectrum-bot

Test result: http://opensource.adobe.com/spectrum-css-vr-results/de8ab46-result-2020-06-10_21-18-23/html_report/

Dev Site: http://opensource.adobe.com/spectrum-css-vr-results/de8ab46-result-2020-06-10_21-18-23/dist/docs/

adobe-spectrum-bot avatar Jun 10 '20 21:06 adobe-spectrum-bot

Test result: http://opensource.adobe.com/spectrum-css-vr-results/4ebd50b-result-2020-06-10_21-53-48/html_report/

Dev Site: http://opensource.adobe.com/spectrum-css-vr-results/4ebd50b-result-2020-06-10_21-53-48/dist/docs/

adobe-spectrum-bot avatar Jun 10 '20 21:06 adobe-spectrum-bot

Hi, @jianliao ... this is waiting on design, but in the meanwhile can you fix the merge conflicts here? Thanks!

misterbrownlee avatar Aug 31 '20 19:08 misterbrownlee

@pfulton Much of this PR seems out of date at this time. Should we go ahead and close it or are there still updates in here we need?

castastrophe avatar Jan 03 '23 15:01 castastrophe

I'm going to go ahead and close this for now since it seems much of these updates have made their way into the repo through other avenues. If there's something in here we still need, feel free to reopen!

castastrophe avatar Jan 12 '23 15:01 castastrophe