spectrum-css icon indicating copy to clipboard operation
spectrum-css copied to clipboard

docs(textarea): add corrected guidelines link and rootClass

Open marissahuysentruyt opened this issue 1 year ago • 3 comments

  • adds a spectrum-Textarea rootClass to textarea component. It doesn't have any styles, is strictly an addition and doesn't overwrite/interfere with the textfield component in the text area template.
  • adds an additional spectrum object to contain the text area guidance link

Description

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • [ ] The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • [ ] VRTs have been run and looked at.
  • [ ] Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

To-do list

  • [ ] I have read the contribution guidelines.
  • [ ] I have updated relevant storybook stories and templates.
  • [ ] I have tested these changes in Windows High Contrast mode.
  • [ ] If my change impacts other components, I have tested to make sure they don't break.
  • [ ] If my change impacts documentation, I have updated the documentation accordingly.
  • [ ] ✨ This pull request is ready to merge. ✨

marissahuysentruyt avatar Oct 25 '24 14:10 marissahuysentruyt

⚠️ No Changeset found

Latest commit: 64192ffff30ced56a822d1400d0dd23c3960d572

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Oct 25 '24 14:10 changeset-bot[bot]

🚀 Deployed on https://pr-3326--spectrum-css.netlify.app

github-actions[bot] avatar Oct 25 '24 14:10 github-actions[bot]

File metrics

Summary

Total size: 4.26 MB*

🎉 No changes detected in any packages

* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

github-actions[bot] avatar Oct 25 '24 14:10 github-actions[bot]

@marissahuysentruyt I wasn't sure about this test case, is this still accurate with the --sizeM at the end?

When inspecting any of the text area templates, the additional spectrum-Textfield--multiline--sizeM class has been added to the parent container. (this has no other styles, besides the styles for spectrum-Textfield--multiline)

castastrophe avatar Oct 30 '24 13:10 castastrophe