chore: dialog t-shirt sizing

[marissahuysentruyt]

Description

This PR aligns the sizing classes for the dialog component to t-shirt sizing, as most of our other components have done in recent years. The old size modifier classes will be deprecated and removed in S2, so deprecation comments were left in the CSS, along with the addition of the t-shirt classes.

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

• [ ] Pull down the branch to run locally, or use the deploy preview.
• [ ] Verify that the old classes are being applied to dialogs, as before. This change introduces NO markup/template/class name changes.
• [ ] Pick a dialog to inspect in the browser. Remove the old class name and add the new class. Ensure that the styles do not change between these classes:

old class name	new class name
spectrum-Dialog--small	spectrum-Dialog--sizeS
spectrum-Dialog--medium	spectrum-Dialog (the default, so no size is necessary)
spectrum-Dialog--large	spectrum-Dialog--sizeL

Regression testing

Validate:

1. The documentation pages for at least two other components are still loading, including:

• [ ] The pages render correctly, are accessible, and are responsive.

2. If components have been modified, VRTs have been run on this branch:

• [ ] VRTs have been run and looked at.
• [ ] Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

To-do list

• [ ] I have read the contribution guidelines.
• [ ] I have updated relevant storybook stories and templates.
• [ ] I have tested these changes in Windows High Contrast mode.
• [ ] If my change impacts other components, I have tested to make sure they don't break.
• [ ] If my change impacts documentation, I have updated the documentation accordingly.
• [ ] ✨ This pull request is ready to merge. ✨

[changeset-bot[bot]]

🦋 Changeset detected

Latest commit: 93f309f7ef9140129c6fd3dde299429c8f6429c6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@spectrum-css/dialog	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions[bot]]

🚀 Deployed on https://pr-3322--spectrum-css.netlify.app

[github-actions[bot]]

File metrics

Summary

Total size: 4.30 MB^* Total change (Δ): 🔴 ⬆ 0.12 KB (0.00%)

Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.

Package	Size	Δ
dialog	14.68 KB	🔴 ⬆ 0.04 KB

Details

dialog

Filename	Head	Compared to base
index-base.css	14.68 KB	🔴 ⬆ 0.04 KB (0.27%)
index-vars.css	14.68 KB	🔴 ⬆ 0.04 KB (0.27%)
index.css	14.68 KB	🔴 ⬆ 0.04 KB (0.27%)

* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.