fix(coachmark): correct invalid token pointers in pagination styles [CSS-1011]
Description
During S2 development, I noticed a regression in pagination styles for the Coach Mark step and discovered this was due to font styles pointing to spectrum tokens that are not defined. There are however unused tokens defined with similar names. This PR points those typography elements to the appropriate styles.
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
See comment below for verification via the visual regression test results.
Regression testing
Validate:
- The documentation pages for at least two other components are still loading, including:
- [x] The pages render correctly, are accessible, and are responsive.
- If components have been modified, VRTs have been run on this branch:
- [x] VRTs have been run and looked at.
- [x] Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.
Screenshots
To-do list
- [x] I have read the contribution guidelines.
- [x] I have updated relevant storybook stories and templates.
- [x] I have tested these changes in Windows High Contrast mode.
- [x] ✨ This pull request is ready to merge. ✨
🦋 Changeset detected
Latest commit: 3d9ac8bf80dc31c04e5c1dbdf549f4762b0b9680
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| @spectrum-css/coachmark | Minor |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
🚀 Deployed on https://pr-3292--spectrum-css.netlify.app
File metrics
Summary
Total size: 4.30 MB* Total change (Δ): 🔴 ⬆ 0.16 KB (0.00%)
Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.
| Package | Size | Δ |
|---|---|---|
| coachmark | 7.81 KB | 🔴 ⬆ 0.05 KB |
Details
coachmark
| Filename | Head | Compared to base |
|---|---|---|
| index-base.css | 7.81 KB | 🔴 ⬆ 0.05 KB (0.65%) |
| index-vars.css | 7.81 KB | 🔴 ⬆ 0.05 KB (0.65%) |
| index.css | 7.81 KB | 🔴 ⬆ 0.05 KB (0.65%) |
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.
Expected visual regressions show assignment of the line-height and typography values to the pagination: https://www.chromatic.com/build?appId=64762974a45b8bc5ca1705a2&number=3529