spectrum-css icon indicating copy to clipboard operation
spectrum-css copied to clipboard

docs(inlinealert,link,logicbutton,miller): docs migration from static site to storybook

Open marissahuysentruyt opened this issue 1 year ago • 3 comments

Description

This PR continues migrating documentation from the docs site into Storybook. The focus is on inlinealert, link, logicbutton and miller. All variants of the component should now be displayed on the Storybook Docs page. Additionally, Chromatic coverage was added to inlinealert, link, and logicbutton.

  • inlinealert: new stories and enhanced chromatic coverage
  • link: new stories and added chromatic coverage
  • logicbutton: enhanced chromatic coverage
  • miller: new story descriptions

This PR doesn't need a changeset since it's docs only.

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

  • [ ] The inline alert docs page matches all content found on the docs site
  • [ ] Using the chromatic preview should display all variants of the inline alert in the default/neutral story.
  • [ ] The link docs page matches all content found on the docs site
  • [ ] Using the chromatic preview should display all variants of the link in the default story.
  • [ ] The logic button docs page matches all content found on the docs site
  • [ ] Using the chromatic preview should display all variants of the logic button.
  • [ ] The miller columns docs page matches all content found on the docs site

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • [ ] The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • [ ] VRTs have been run and looked at.
  • [ ] Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

To-do list

  • [x] I have read the contribution guidelines.
  • [x] I have updated relevant storybook stories and templates.
  • [x] I have tested these changes in Windows High Contrast mode.
  • [ ] If my change impacts other components, I have tested to make sure they don't break.
  • [x] If my change impacts documentation, I have updated the documentation accordingly.
  • [ ] ✨ This pull request is ready to merge. ✨

marissahuysentruyt avatar Jul 02 '24 15:07 marissahuysentruyt

⚠️ No Changeset found

Latest commit: ca10df50a230a1914496dc756325fe4207a53f2f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jul 02 '24 15:07 changeset-bot[bot]

🚀 Deployed on https://pr-2884--spectrum-css.netlify.app

github-actions[bot] avatar Jul 02 '24 15:07 github-actions[bot]

File metrics

Summary

Total size: 4.63 MB*

🎉 No changes detected in any packages

* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

github-actions[bot] avatar Jul 02 '24 15:07 github-actions[bot]