spectrum-css icon indicating copy to clipboard operation
spectrum-css copied to clipboard

chore(accordion,actionbar,actionbutton,alertdialog): group tests and import from templates

Open castastrophe opened this issue 1 year ago • 3 comments

Description

Minor updates to the storybooks for:

  • accordion
  • actionbar
  • actionbutton
  • alertdialog

Summary of changes:

  • Import group tests from the template.js file
  • Change window.isChromatic() checks to hide/show instead of add or remove (this helps with the too many hooks warning)
  • Expand coverage for action bar

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • [ ] The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • [ ] VRTs have been run and looked at.
  • [ ] Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

To-do list

  • [ ] I have read the contribution guidelines.
  • [ ] I have updated relevant storybook stories and templates.
  • [ ] I have tested these changes in Windows High Contrast mode.
  • [ ] If my change impacts other components, I have tested to make sure they don't break.
  • [ ] If my change impacts documentation, I have updated the documentation accordingly.
  • [ ] ✨ This pull request is ready to merge. ✨

castastrophe avatar Jun 07 '24 19:06 castastrophe