spectrum-css icon indicating copy to clipboard operation
spectrum-css copied to clipboard

fix(textarea): drag and grow behaviors

Open jenndiaz opened this issue 1 year ago • 3 comments

Description

Updates text area to display grow and drag behaviors.

Design Guidance:

  • TextArea should display drag by default
  • When grow is enabled this drag behavior and icon should go away

Changes:

  • Update CSS for all text areas to be draggable by default
  • update docs site to include grow description

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

On the docs page for TextArea

  • [x] All variants, expect for grows, should be draggable
  • [ ] Validation icons stay aligned on top of the textarea after resize.

In storybook:

  • [x] TextArea is draggable by default
  • [x] drag behavior goes away with Grows control toggled to true
  • [ ] Validation icons stay aligned on top of the textarea after resize. Include testing in Chromatic-only view of Storybook.

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • [x] The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • [ ] VRTs have been run and looked at.
  • [ ] Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

Before

Screenshot 2024-02-09 at 2 36 32 PM

After

Screenshot 2024-02-09 at 2 39 23 PM

To-do list

  • [x] I have read the contribution guidelines.
  • [x] I have updated relevant storybook stories and templates.
  • [x] I have tested these changes in Windows High Contrast mode.
  • [x] If my change impacts other components, I have tested to make sure they don't break.
  • [x] If my change impacts documentation, I have updated the documentation accordingly.
  • [ ] ✨ This pull request is ready to merge. ✨

jenndiaz avatar Feb 09 '24 16:02 jenndiaz