spectrum-css icon indicating copy to clipboard operation
spectrum-css copied to clipboard

[picker] "block" => "inline" mismatch?

Open Westbrook opened this issue 2 years ago • 2 comments

https://github.com/adobe/spectrum-css/blob/f5262ea9a7d1968223dfcaf90a2af4100f7092b7/components/picker/index.css#L203

Here we see min-inline-size set to block-size, is that expected?

Westbrook avatar May 18 '23 12:05 Westbrook

@Westbrook I can double check but as I understand it, we're calculating the minimum width based on the size of the height * the multiplier. I believe that's on purpose however I do notice there's no override for min-inline-size either. Perhaps:

 min-inline-size: var(--mod-picker-inline-size, calc(var(--spectrum-picker-minimum-width-multiplier) * var(--mod-picker-block-size, var(--spectrum-picker-block-size)))); 

castastrophe avatar Jul 12 '23 18:07 castastrophe

I think that makes sense. If the calculation is expected, a --mod-* value to ensure we still have full control over the width without altering the height should cover the bases.

Aside: oy, it is hard to think outloud in logical properties. 🙃

Westbrook avatar Jul 12 '23 19:07 Westbrook