spectrum-css icon indicating copy to clipboard operation
spectrum-css copied to clipboard
verified publisher icon adobe

fix(slider): ensure margin-block is correct for range variant

Open Westbrook opened this issue 4 years ago • 1 comments

Description

Correct margin-block-start in Range variant of Slider component.

fixes #1205

How and where has this been tested?

  • How this was tested: Visually inspecting the local build of the documentation site
  • Browser(s) and OS(s) this was tested with: Stable Chrome on Catalina

Screenshots

Before: image After: image

To-do list

  • [ ] If my change impacts other components, I have tested to make sure they don't break.
  • [ ] If my change impacts documentation, I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [x] This pull request is ready to merge.

Westbrook avatar Jun 11 '21 10:06 Westbrook

VRT successfully! :confetti_ball:

View the VRT result

adobe-spectrum-bot avatar Jun 11 '21 10:06 adobe-spectrum-bot

I suspect PR #1547 will end up superseding this so I've highlighted this PR there to ensure changes address this concern.

castastrophe avatar Jan 03 '23 15:01 castastrophe

I suspect PR #1547 will end up superseding this so I've highlighted this PR there to ensure changes address this concern.

yes @castastrophe. This is part of https://github.com/adobe/spectrum-css/pull/1547 where the padding has been corrected for Range and regular Slider variant.

bernhard-adobe avatar Jan 10 '23 23:01 bernhard-adobe

Awesome, thanks @bernhard-adobe for confirming and thank you @Westbrook for the contribution! Closing this out in favor of the rewrite work.

castastrophe avatar Jan 12 '23 15:01 castastrophe