react-spectrum
react-spectrum copied to clipboard
adobe
Add Edit this page button to docs
This should make it easier for people to contribute doc fixes I pass the filepath through and store it in a meta tag in a data attribute, so it shouldn't conflict with anything now or in the future We could limit the pages that it appears on, but I haven't done that right now
Closes
✅ Pull Request Checklist:
- [ ] Included link to corresponding React Spectrum GitHub Issue.
- [ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
- [ ] Filled out test instructions.
- [ ] Updated documentation (if it already exists for this component).
- [ ] Looked at the Accessibility Practices for this feature - Aria Practices
📝 Test Instructions:
🧢 Your Project:
hey -- do we want to get this in? seems like a good change.
my only question -- what do we think about moving this to the bottom right? Like more inline with the TOC - but at the bottom. Feels like it will be less intrusive.
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
as seen at the bottom of parcel docs https://parceljs.org/features/development/
Build successful! 🎉
Build successful! 🎉
Still looks good. Do we want the url to end with
?plain=1so it's "raw" mode which feels more like an edit mode?
Going to just follow the parcel example for now.
Build successful! 🎉
Build successful! 🎉
couple of conflicts on this PR, but looks fine to me in its current state. Did you also want to go ahead and change the button to an <a> with button css?
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
## API Changes
unknown top level export { type: 'identifier', name: 'Column' } unknown top level export { type: 'identifier', name: 'Column' } unknown type { type: 'link' } unknown type { type: 'link' } unknown type { type: 'link' } unknown type { type: 'link' } unknown type { type: 'link' } unknown type { type: 'link' }