chore: Deprecate old prop isTextInput on useFocusVisible
Closes https://github.com/adobe/react-spectrum/issues/5658
โ Pull Request Checklist:
- [ ] Included link to corresponding React Spectrum GitHub Issue.
- [ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
- [ ] Filled out test instructions.
- [ ] Updated documentation (if it already exists for this component).
- [ ] Looked at the Accessibility Practices for this feature - Aria Practices
๐ Test Instructions:
๐งข Your Project:
Build successful! ๐
Doesn't this change the behavior though? Why are we deprecating it?
@devongovett i don't think so, at least, i didn't notice any changes in testing. Idea came from @LFDanLu 's comment https://github.com/adobe/react-spectrum/issues/5658#issuecomment-1879465094
Build successful! ๐
## API Changes
@react-aria/focus
/@react-aria/focus:FocusRing
FocusRing {
autoFocus?: boolean
children: ReactElement
focusClass?: string
focusRingClass?: string
- isTextInput?: boolean
within?: boolean = false
}
/@react-aria/focus:FocusRingProps
FocusRingProps {
autoFocus?: boolean
children: ReactElement
focusClass?: string
focusRingClass?: string
- isTextInput?: boolean
within?: boolean = false
}
/@react-aria/focus:AriaFocusRingProps
AriaFocusRingProps {
autoFocus?: boolean
- isTextInput?: boolean
within?: boolean = 'false'
}
@react-aria/interactions
/@react-aria/interactions:FocusVisibleProps
FocusVisibleProps {
autoFocus?: boolean
- isTextInput?: boolean
}
We still need this prop because of https://github.com/adobe/react-spectrum/pull/7625#discussion_r1920789125, closing