react-spectrum icon indicating copy to clipboard operation
react-spectrum copied to clipboard

chore: Deprecate old prop isTextInput on useFocusVisible

Open snowystinger opened this issue 1 year ago โ€ข 5 comments

Closes https://github.com/adobe/react-spectrum/issues/5658

โœ… Pull Request Checklist:

  • [ ] Included link to corresponding React Spectrum GitHub Issue.
  • [ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • [ ] Filled out test instructions.
  • [ ] Updated documentation (if it already exists for this component).
  • [ ] Looked at the Accessibility Practices for this feature - Aria Practices

๐Ÿ“ Test Instructions:

๐Ÿงข Your Project:

snowystinger avatar Aug 27 '24 08:08 snowystinger

Doesn't this change the behavior though? Why are we deprecating it?

devongovett avatar Aug 27 '24 12:08 devongovett

@devongovett i don't think so, at least, i didn't notice any changes in testing. Idea came from @LFDanLu 's comment https://github.com/adobe/react-spectrum/issues/5658#issuecomment-1879465094

snowystinger avatar Aug 27 '24 23:08 snowystinger

## API Changes

@react-aria/focus

/@react-aria/focus:FocusRing

 FocusRing {
   autoFocus?: boolean
   children: ReactElement
   focusClass?: string
   focusRingClass?: string
-  isTextInput?: boolean
   within?: boolean = false
 }

/@react-aria/focus:FocusRingProps

 FocusRingProps {
   autoFocus?: boolean
   children: ReactElement
   focusClass?: string
   focusRingClass?: string
-  isTextInput?: boolean
   within?: boolean = false
 }

/@react-aria/focus:AriaFocusRingProps

 AriaFocusRingProps {
   autoFocus?: boolean
-  isTextInput?: boolean
   within?: boolean = 'false'
 }

@react-aria/interactions

/@react-aria/interactions:FocusVisibleProps

 FocusVisibleProps {
   autoFocus?: boolean
-  isTextInput?: boolean
 }

rspbot avatar Oct 16 '24 06:10 rspbot

We still need this prop because of https://github.com/adobe/react-spectrum/pull/7625#discussion_r1920789125, closing

LFDanLu avatar Apr 12 '25 00:04 LFDanLu