react-spectrum
react-spectrum copied to clipboard
adobe
Support "aria-keyshortcuts" in react-aria-components
Provide a general summary of the feature here
I want to be able to set aria-keyshortcuts on a Button.
🤔 Expected Behavior?
<Button aria-keyshortcuts="S" />
It should add the property on the element.
😯 Current Behavior
It does not work.
💁 Possible Solution
No response
🔦 Context
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-keyshortcuts
💻 Examples
No response
🧢 Your Company/Team
Argos
🕷 Tracking Issue
No response
I think we could add this to AriaBaseButtonProps here: https://github.com/adobe/react-spectrum/blob/cef3714bb8816a4ee64ffb1d0730f2669738d2e4/packages/%40react-types/button/src/index.d.ts#L49-L63
Just to make sure I understand, just putting the attribute on one of our elements won't do anything other than read off to AT?
It doesn't actually do anything right? If so, then I think this is fine. Though it sounds like it's supported on every HTML element? it's going to be harder to decide which components it makes sense on. What all do you want it on so far? Just button?
@snowystinger Yeah, I think just Button is a good start, and maybe Link as well.