react-spectrum icon indicating copy to clipboard operation
react-spectrum copied to clipboard

Update storybook actions depth to 2

Open reidbarber opened this issue 1 year ago โ€ข 1 comments

This should help fix a noticeable lag after the Storybook 7 upgrade.

Note that the depth can be overridden at the individual action level, if we ever do want more depth for specific actions.

โœ… Pull Request Checklist:

  • [ ] Included link to corresponding React Spectrum GitHub Issue.
  • [ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • [ ] Filled out test instructions.
  • [ ] Updated documentation (if it already exists for this component).
  • [ ] Looked at the Accessibility Practices for this feature - Aria Practices

๐Ÿ“ Test Instructions:

Test by opening a Combobox in storybook:

Before Change

After Change

๐Ÿงข Your Project:

RSP

reidbarber avatar May 15 '24 14:05 reidbarber

@snowystinger 2 seemed reasonable and performance was noticeably improved. I just tried 1 and it seems to behave the same as 2. I think this is a bug in 7.0: https://github.com/storybookjs/storybook/issues/21933. I also tried 0 and it seems like the depth didn't apply at all in that case.

reidbarber avatar May 20 '24 18:05 reidbarber

## API Changes

unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any', access: 'private' } unknown top level export { type: 'any', access: 'private' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'identifier', name: 'Column' } unknown top level export { type: 'identifier', name: 'Column' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown type { type: 'link' } unknown type { type: 'link' } unknown type { type: 'link' } unknown type { type: 'link' } unknown type { type: 'link' } unknown type { type: 'link' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' }

rspbot avatar May 22 '24 00:05 rspbot