react-spectrum fix(#3220): DragManager force forms mode when dragging

Closes #3220

✅ Pull Request Checklist:

[x] Included link to corresponding React Spectrum GitHub Issue #3220.
[x] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
[x] Filled out test instructions.
[ ] Updated documentation (if it already exists for this component).
[x] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Using Windows with either JAWS or NVDA screen reader, open https://reactspectrum.blob.core.windows.net/reactspectrum/686489b2774e1238e3c4f1abc42593cbbba5e92b/storybook/index.html?path=/story/drag-and-drop--default&id=drag-and-drop--default&providerSwitcher-toastPosition=bottom&viewMode=story
In browse mode/virtual cursor mode, navigate to the button labelled "Drag me."
The dragDescriptionVirtual message, "Click to start dragging." does not get announced.
Press Space or Enter key to activate the "Drag me" button and start dragging.
NVDA or JAWS should shift into forms mode.
The live announcer will announce the, dragStartedVirtual message, "Started dragging. Navigate to a drop target, then click or press Enter to drop," followed by the endDragVirtual message, "Dragging. Click to cancel drag."
Use down arrow to move the virtual cursor to the first available drop target, a button labelled, "Drop here."
The screen reader should to announce the dropDescriptionVirtual, "Click to drop."
Press Enter key to complete drop action.
The live announcer will announce the dropComplete message, "Drop complete."

🧢 Your Project:

Adobe/Accessibility

Jun 13 '22 17:06 majornista

Build successful! 🎉

Jun 13 '22 18:06 adobe-bot

Build successful! 🎉

Jun 14 '22 16:06 adobe-bot

Build successful! 🎉

Jun 14 '22 22:06 adobe-bot

Build successful! 🎉

Jun 15 '22 14:06 adobe-bot

Build successful! 🎉

Jun 22 '22 19:06 adobe-bot

Build successful! 🎉

Jun 27 '22 14:06 adobe-bot

Build successful! 🎉

Jul 11 '22 19:07 adobe-bot

Build successful! 🎉

Jul 14 '22 15:07 adobe-bot

Build successful! 🎉

Aug 04 '22 22:08 adobe-bot

I want to investigate why adding role="application" to document.body doesn't work as you mentioned in https://github.com/adobe/react-spectrum/pull/3221#discussion_r897042186. With the current implementation this may still happen, for example, if the common ancestor of all of the drop targets is the body. Not sure how we would handle that case if adding role="application" to the body really doesn't work. Since dnd is in our current priorities, we'll look at this before the GA release unless you get to it first.

Aug 08 '22 20:08 devongovett

Build successful! 🎉

Aug 10 '22 19:08 adobe-bot

Build successful! 🎉

Aug 12 '22 16:08 adobe-bot

Build successful! 🎉

Aug 16 '22 20:08 adobe-bot

Build successful! 🎉

Sep 09 '22 14:09 adobe-bot

Build successful! 🎉

Sep 12 '22 20:09 adobe-bot

Build successful! 🎉

Sep 15 '22 22:09 adobe-bot

Build successful! 🎉

Sep 16 '22 17:09 adobe-bot

Build successful! 🎉

Sep 23 '22 19:09 adobe-bot

Build successful! 🎉

Sep 23 '22 21:09 adobe-bot

What's the status of this PR? I think a recently merged PR of Devon's addressed some of this last I heard

Oct 05 '22 22:10 snowystinger

What's the status of this PR? I think a recently merged PR of Devon's addressed some of this last I heard

I think we may be able to close this. Rakesh tested with and without this change, and I think the behavior using role="application" wasn't significantly better. Drag and Drop now announces when the Drag operation starts, and we hide non-drop targets, so forcing forms mode doesn't do much beyond forcing thus user to Tab, which Rakesh actually found somewhat confusing.

Oct 06 '22 17:10 majornista

react-spectrum react-spectrum copied to clipboard

fix(#3220): DragManager force forms mode when dragging

✅ Pull Request Checklist:

📝 Test Instructions:

🧢 Your Project:

react-spectrum
react-spectrum copied to clipboard