react-spectrum
react-spectrum copied to clipboard
adobe
CSF 3.0 Tooltip and TooltipTrigger
There was a code change!!!!!! TooltipTrigger didn't support shouldFlip or containerPadding. Both of those are now supported.
Part of the Storybook CSF 3.0 migration in issue 3056.
Migration included refactoring to use Storybook controls.
There are changes to Chromatic so we'll need to confirm the migrated stories didn't change and approve the new stories.
- [ ] Run Chromatic and approve the new stories.
✅ Pull Request Checklist:
- [ ] Included link to corresponding React Spectrum GitHub Issue.
- [ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
- [ ] Filled out test instructions.
- [ ] Updated documentation (if it already exists for this component).
- [ ] Looked at the Accessibility Practices for this feature - Aria Practices
📝 Test Instructions:
Review the changes to Tooltip and TooltipTrigger in storybook. Confirm that the correct stories were migrated or dropped, and controls work and make sense.
🧢 Your Project:
RSP
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Here's chromatic for the change https://www.chromatic.com/build?appId=5f0dd5ad2b5fc10022a2e320&number=338
