react-spectrum
react-spectrum copied to clipboard
adobe
Fix useResizeObserver loop limit exceeded warning
Closes https://github.com/adobe/react-spectrum/issues/1924
Uses solution from https://blog.elantha.com/resizeobserver-loop-limit-exceeded/ Story added is based on the code from the blog and it reproduces the issue. You can see this for yourself once this PR builds.
Someone pinged on the issue again and our project's complain about this periodically. I had a solution laying around so put it into a PR. This isn't a priority for our next release, but is a general nice to have.
✅ Pull Request Checklist:
- [x] Included link to corresponding React Spectrum GitHub Issue.
- [ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
- [ ] Filled out test instructions.
- [ ] Updated documentation (if it already exists for this component).
- [ ] Looked at the Accessibility Practices for this feature - Aria Practices
📝 Test Instructions:
Make sure ActionGroups still collapse as expected. Shouldn't see any warnings about loop limit exceeded. Other components using it that should be verified in testing: ActionGroup ScrollView SearchAutocomplete Breadcrumbs ButtonGroup CardBase ColorWheel ComboBox DatePicker Picker SearchWithin Tabs
🧢 Your Project:
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
## API Changes
unknown top level export { type: 'identifier', name: 'Column' } unknown top level export { type: 'identifier', name: 'Column' } unknown type { type: 'link' } unknown type { type: 'link' } unknown type { type: 'link' } unknown type { type: 'link' } unknown type { type: 'link' } unknown type { type: 'link' }
