react-spectrum icon indicating copy to clipboard operation
react-spectrum copied to clipboard

WIP add steplist componente

Open razvanip opened this issue 3 years ago • 0 comments

Closes

✅ Pull Request Checklist:

  • [ ] Included link to corresponding React Spectrum GitHub Issue.
  • [ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • [ ] Filled out test instructions.
  • [ ] Updated documentation (if it already exists for this component).
  • [ ] Looked at the Accessibility Practices for this feature - Aria Practices

I took the great work @itaylor did on step list and did some of the changes that were discussed like:

  • changed aria hooks to fallow same pattern, like the rest of the components passing props state ref to get the components DOM props
  • added keyboard delegation for useStepList currently it's the same like for tabs but i will fallow with spectrum design to get the corect keyboard navigation behaviour
  • added support for useSelectableCollection in useStepList
  • moved aria-${props} out of useStepItem to StepItem to fallow the same pattern with the rest of the components

My Plan:

  • revisit styling and make sure we are aligned with UX
  • address some comments from @snowystinger regarding flex
  • add docs
  • refactor stories and add more examples

Let me know your thoughts

razvanip avatar Feb 10 '22 18:02 razvanip