react-spectrum
react-spectrum copied to clipboard
WIP add steplist componente
Closes
✅ Pull Request Checklist:
- [ ] Included link to corresponding React Spectrum GitHub Issue.
- [ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
- [ ] Filled out test instructions.
- [ ] Updated documentation (if it already exists for this component).
- [ ] Looked at the Accessibility Practices for this feature - Aria Practices
I took the great work @itaylor did on step list and did some of the changes that were discussed like:
- changed
aria
hooks to fallow samepattern
, like the rest of the components passingprops
state
ref
to get the componentsDOM
props - added
keyboard
delegation foruseStepList
currently it's the same like fortabs
but i will fallow withspectrum
design to get the corectkeyboard
navigation behaviour - added support for
useSelectableCollection
inuseStepList
- moved
aria-${props}
out ofuseStepItem
toStepItem
to fallow the same pattern with the rest of the components
My Plan:
- revisit
styling
and make sure we are aligned withUX
- address some comments from @snowystinger regarding
flex
- add docs
- refactor
stories
and add more examples
Let me know your thoughts