react-spectrum icon indicating copy to clipboard operation
react-spectrum copied to clipboard

Published 20 hours ago • verified publisher icon adobe

New property 'container' for DialogContainer

Open padmkris123 opened this issue 3 years ago • 1 comments

Closes 2540

✅ Pull Request Checklist:

  • [✅] Included link to corresponding React Spectrum GitHub Issue.
  • [✅] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • [✅] Filled out test instructions.
  • [✅] Updated documentation (if it already exists for this component).
  • [✅] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Specify an HTML Element through 'container' property to DialogContainer. Upon open, the dialog DOM will be added under the container specified.

🧢 Your Project:

Adobe / Acrobat Sign

padmkris123 avatar Nov 10 '21 22:11 padmkris123

Since you are an Adobe employee, you don't need to sign the CLA, but join the Adobe org on GitHub. Then it should automatically recognize this. There are instructions in the #react-spectrum slack channel.

devongovett avatar Nov 11 '21 19:11 devongovett

Closing for now due to https://github.com/adobe/react-spectrum/issues/2540#issuecomment-973643172, but feel free to re-open if needed.

reidbarber avatar Jun 07 '23 21:06 reidbarber