jsonschema2md icon indicating copy to clipboard operation
jsonschema2md copied to clipboard

Remove direct reference to ns.adobe in code

Open Relequestual opened this issue 5 years ago • 4 comments

https://github.com/adobe/jsonschema2md/blob/60d9211f034e44e9727e8f8be2ce547ca191d4e1/lib/header.js#L14

lib/header.js includes a direct reference to an adobe URL. If this tool is to be used by the community (which I understand is the intent moving forward), this is probaby not something that should remain, and should in stead be relocated to a configuration file...

Related: https://github.com/adobe/jsonschema2md/issues/112

Relequestual avatar Apr 01 '19 12:04 Relequestual

Sounds reasonable. But I think this was due to some requirement. I am not sure. @trieloff would be better able to comment on this.

anjankaur avatar Apr 03 '19 18:04 anjankaur

This is the extensibility mechanism we've implemented for XDM: https://github.com/adobe/xdm/blob/master/docs/extensions.md

Moving it to a config sounds reasonable, but we should not break the way it works right now.

trieloff avatar Apr 15 '19 08:04 trieloff

OK. I guess it depends where / how you use this, and if you're willing for the default in the cofig to be "off" or "" or something which doesn't include that URL, and for the URL to be in the config for the app / location you're using this library. Make sense?

Relequestual avatar Apr 15 '19 08:04 Relequestual

I think as long as we properly communicate the breaking change (and how to turn it on again) to @fmeschbe and @kstreeter, we should be good.

trieloff avatar Apr 15 '19 09:04 trieloff