jsonschema2md
jsonschema2md copied to clipboard
Remove direct reference to ns.adobe in code
https://github.com/adobe/jsonschema2md/blob/60d9211f034e44e9727e8f8be2ce547ca191d4e1/lib/header.js#L14
lib/header.js
includes a direct reference to an adobe URL.
If this tool is to be used by the community (which I understand is the intent moving forward), this is probaby not something that should remain, and should in stead be relocated to a configuration file...
Related: https://github.com/adobe/jsonschema2md/issues/112
Sounds reasonable. But I think this was due to some requirement. I am not sure. @trieloff would be better able to comment on this.
This is the extensibility mechanism we've implemented for XDM: https://github.com/adobe/xdm/blob/master/docs/extensions.md
Moving it to a config sounds reasonable, but we should not break the way it works right now.
OK. I guess it depends where / how you use this, and if you're willing for the default in the cofig to be "off" or "" or something which doesn't include that URL, and for the URL to be in the config for the app / location you're using this library. Make sense?
I think as long as we properly communicate the breaking change (and how to turn it on again) to @fmeschbe and @kstreeter, we should be good.