the discover command does not use the proxy set via the env vars HTTP_PROXY, HTTPS_PROXY

[shazron]

Expected Behaviour

The discover command uses the proxy set via the environment variables HTTP_PROXY and/or HTTPS_PROXY.

Actual Behaviour

The discover command does not use the proxy set via the environment variables HTTP_PROXY and/or HTTPS_PROXY.

Reproduce Scenario (including but not limited to)

1. Run a proxy locally, use the proxy code at mitmproxy.org.
2. For your App Builder project, set the env vars HTTP_PROXY and HTTPS_PROXY to http://127.0.0.1:8080 and https://127.0.0.1:8080 respectively
3. Verify that the proxy settings are set via running aio info
4. Run aio discover - it should hit the proxy, but it does not (see logs in the Terminal)

Investigation

We use node-fetch directly, without setting any proxy server configuration via the environment variables.

Proposed Fix

Use the proxied fetch implementation in @adobe/aio-lib-core-networking instead of node-fetch.

Workaround

There is no true workaround since node.js does not use system proxy settings (so you can't set it there). The only way for the command to work is to not use the proxy.

[aiojbot]

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-3142