aem-testing-clients icon indicating copy to clipboard operation
aem-testing-clients copied to clipboard

DefaultReplicationAgents rule doesn't normalize replication target URIs

Open actinium15 opened this issue 4 years ago • 3 comments

at [0], DefaultReplicationAgents configures the replication agents with supplied serverUrl + /bin/receive as transport URI. However, since the serverUrl may have a trailing character, [0] should normalize the replication target URI before updating the replication agent config to avoid double slashes in the target URI.

[0] https://github.com/adobe/aem-testing-clients/blob/cq-65/src/main/java/com/adobe/cq/testing/junit/rules/DefaultReplicationAgents.java#L103

actinium15 avatar May 26 '20 05:05 actinium15

@dulvac, @actinium15 We are still facing this issue in assets' nightly job when the requests to publish are intermittently failing when the URL contains double slash. Can this issue be prioritized?

mohiaror avatar Nov 28 '20 19:11 mohiaror

We are still facing this issue in nightly job when the requests to publish are intermittently failing when the URL contains double slash.

Hi @mohiaror, I wouldn't expect this issue to appear intermittently if the URLs contain double slashes - it should appear consistently for all urls with double slashes. Can you please reconfirm the statu? Also, I recall this being fixed within AEM since the time this particular github issue was opened. Can you please confirm if AEM is able to process requests with double slashes or not (perhaps using curl)?

actinium15 avatar Nov 29 '20 16:11 actinium15

@actinium15

I wouldn't expect this issue to appear intermittently if the URLs contain double slashes - it should appear consistently for all urls with double slashes. Can you please reconfirm the statu?

Yes, I can see double slashes even in the logs of the jobs which are successful.

Also, I recall this being fixed within AEM since the time this particular github issue was opened. Can you please confirm if AEM is able to process requests with double slashes or not (perhaps using curl)

It seems this is where the intermittent behavior is observed. Sometimes the requests are correctly processed and sometimes they throw error. I will investigate more and log an AEM issue for this.

But would you guys suggest that this issue should also be fixed in the meanwhile?

mohiaror avatar Dec 01 '20 07:12 mohiaror