assets.cy.js: @completeupload invocation does not complete if invoked with cy.wait construct

[sachinlala]

Expected Behaviour

assets.cy.js >> @completeupload should complete successfully, when the image path and previous steps are correct

Actual Behaviour

assets.cy.js >> @completeupload times-out while the status of asset upload is 'Processing'

Steps to Reproduce

npx cypress run --headed --no-exit --browser chrome >> reports timeout for @completeupload step

Enhancement Proposal

Instead of cy.wait, we can rather invoke the more deterministic cy.waitUntil - as follows:

    // wait for the /content/dam.completeUpload.json POST to complete before polling for the asset
    cy.waitUntil(
        () => ['@completeupload'], {
          errorMsg: `asset ${imagePath} should be uploaded`,
          timeout: 5000,
          interval: 1000
        }
    );

Please let me know if this looks ok - will accordingly raise a PR.

[dulvac]

@sachinlala , Sorry for the long delay. I think that sounds good. Feel free to raise a PR