aem-react-editable-components icon indicating copy to clipboard operation
aem-react-editable-components copied to clipboard

Made PageProps componentMapping property optional as it is already trated as optional inside the component

Open RomanKontsevoi opened this issue 1 year ago • 0 comments
trafficstars

Description

Just made componentMapping prop optioanl because it is already treated as optional

Related Issue

https://github.com/adobe/aem-react-editable-components/issues/225

Motivation and Context

Less TS errors using the library

How Has This Been Tested?

I hadn't made tests, because it is a really straightforward and tiny only TS-related fix. The error itself says that the issue is that 'componentMapping' property is required, however the code itself assumes it can be not defined:

const PageList = ({ cqChildren, ...props }: PageProps): JSX.Element => {
  const componentMapping = props.componentMapping || ComponentMapping;
...

Screenshots (if appropriate):

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x] I have signed the Adobe Open Source CLA.
  • [x] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [x] All new and existing tests passed.

RomanKontsevoi avatar Dec 28 '23 14:12 RomanKontsevoi