aem-project-archetype icon indicating copy to clipboard operation
aem-project-archetype copied to clipboard

Add Archetype Version to archetype.properties file

Open pat-lego opened this issue 3 years ago • 1 comments

As a developer, it is important to know which archetype version was used since it impacts the ability to deploy the project to an AEM instance.

Description

Add archetypeVersion to the archetype.properties file

Related Issue

No related issue just something I wanted to add to the project since it was bothering me that it was not already part of the archetype.properties file.

Motivation and Context

I am always documenting the archetype version used in the README but I would much prefer having it in the archetype.properties file since it already contained much of the archetype options that were entered within the project.

How Has This Been Tested?

  • Added the variable to the archetype-metadata.xml
  • Ran a mvn clean install
  • All tests passed
  • Created a new project from the SNAPSHOT build that was previously built
  • Validated that the archetype.properties file was properly created

Screenshots (if appropriate):

Screen Shot 2021-04-30 at 2 11 05 PM Screen Shot 2021-04-30 at 2 11 14 PM Screen Shot 2021-04-30 at 2 11 20 PM Screen Shot 2021-04-30 at 2 11 28 PM

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x] I have signed the Adobe Open Source CLA.
  • [x] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [x] I have added tests to cover my changes.
  • [x] All new and existing tests passed.

pat-lego avatar Apr 30 '21 18:04 pat-lego

@sharanyavinod would you be able to review this. I am much looking forward to this functionality.

pat-lego avatar May 11 '21 03:05 pat-lego