aem-guides-wknd icon indicating copy to clipboard operation
aem-guides-wknd copied to clipboard

Eliminate jQuery dependency

Open gknobloch opened this issue 2 years ago • 3 comments

Expected Behaviour

No need for jQuery dependency

Actual Behaviour

https://github.com/adobe/aem-guides-wknd/search?q=jquery

Reproduce Scenario (including but not limited to)

N/A

Steps to Reproduce

N/A

Platform and Version

N/A

Sample Code that illustrates the problem

See Github search

Logs taken while reproducing problem

N/A

gknobloch avatar Nov 12 '21 16:11 gknobloch

@gknobloch I can take a stab at this. IIRC it was primarily being used for the mobile nav. I still think its nice to show an example of a 3rd party library so may choose to implement with: https://slideout.js.org/. Unless you have any ideas / recommendations...

godanny86 avatar Nov 12 '21 17:11 godanny86

The main goal is to remove Javascript library dependencies to improve LCP (Largest Contentful Paint) on mobile devices

keepthebyte avatar Nov 13 '21 07:11 keepthebyte

Is this still needed as clientlibs now load async? It still would be nice to ditch jQuery. As this a simple toggle I would not encourage to use any library but implement this with simple js.

Tylopilus avatar Oct 08 '22 21:10 Tylopilus