aem-core-wcm-components icon indicating copy to clipboard operation
aem-core-wcm-components copied to clipboard

[Carousel] Add touch event support

Open frappierer opened this issue 4 years ago • 7 comments

Support for touch events and sliding animation

The carousel component uses display: block and display: none to show and hide the appropriate content.

Problems with this approach

  • Impossible to have a sliding animation
  • Touch or drag events, dont trigger slide changes
  • The need to use third party libraries and rebuild the component from scratch to fill the needs of nearly all our customers
  • With third party libraries, where slides are stored next to each other, the touch-ui breaks (it is x-offset scrollable).

Suggestion

  • remove display: block and display: none , and place slides next to each other
  • register touch events
  • leave touch-ui non scrollable).

frappierer avatar Mar 31 '20 14:03 frappierer

@frappierer thank you, this is valuable input. Yes the current V1 of the carousel has some limitations in this regard. Your changes would most probably require a new version of the carousel.

Judging by your description you already did some work in that direction. Maybe you can provide a PR as a starting point for the next version ?

msagolj avatar Apr 06 '20 11:04 msagolj

@msagolj we could show you what we did. But we used https://flickity.metafizzy.co/license.html. If Adobe would go that way you/adobe need to acquire the Flickity Commercial Organization License for 320 Dollar. Still interested?

frappierer avatar Apr 06 '20 12:04 frappierer

@frappierer I was more thinking in the line of changes required that makes core components carousel more generic, so its easier to extend. But flickity can be used as an example to see what needs to be done.

msagolj avatar Apr 15 '20 07:04 msagolj

Any updates on this one?

AEMBodi avatar May 16 '22 17:05 AEMBodi

Is there an ETA on when the new version of the Carousel component will be released?

jimivine avatar May 02 '23 09:05 jimivine

Still no news about that? I think it's a very important feature.

fahol-coop avatar Jan 09 '24 14:01 fahol-coop