[Page] Extend meta attributes #663

[dymitrs]

Q	A
Fixed Issues?	Fixes #663
Patch: Bug Fix?	Some Sonarlint fixes like deleted redundant throws.
Minor: New Feature?	Yes - OG, Facebook, Twitter meta tags extended, Canonical URL
Major: Breaking Change?	No
Tests Added + Pass?	Yes
Documentation Provided	Yes (code comments and or markdown)
Any Dependency Changes?	Yes, added Apache dependency to Core pom.xml
License	Apache License, Version 2.0

• Extended meta tags attributes - they are configurable on Page policy and can be enabled by checkbox in Properties of page (Social Media tab). Configuration can be extended on Page level. (after enabling a checkbox, textfield could appear where page id, account id or twitter username can be set. If setup this way, configuration from Page properties will be taken as first instead of the page policy conf).
• Added Canonical URL feature for pages that use Page component (for rendition).

[codecov-io]

Codecov Report

Merging #744 into development will increase coverage by 0.04%. The diff coverage is 80.64%.

@@                Coverage Diff                @@
##             development     #744      +/-   ##
=================================================
+ Coverage          82.81%   82.85%   +0.04%     
- Complexity          1096     1111      +15     
=================================================
  Files                110      111       +1     
  Lines               3450     3488      +38     
  Branches             634      640       +6     
=================================================
+ Hits                2857     2890      +33     
- Misses               224      226       +2     
- Partials             369      372       +3

Impacted Files	Coverage Δ	Complexity Δ
...obe/cq/wcm/core/components/internal/PageUtils.java	100% <100%> (ø)	5 <5> (?)
.../wcm/core/components/models/SocialMediaHelper.java	100% <100%> (ø)	10 <3> (+3)	:arrow_up:
.../com/adobe/cq/wcm/core/components/models/Page.java	100% <100%> (ø)	19 <1> (+1)	:arrow_up:
...ents/internal/models/v1/SocialMediaHelperImpl.java	74.62% <73.17%> (-0.1%)	27 <11> (+3)
...m/core/components/internal/models/v2/PageImpl.java	83.92% <88.88%> (+2.29%)	24 <3> (+3)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5fdd670...5f09c30. Read the comment docs.

[dymitrs]

@bpauli @richardhand Hey, could you take a look on the PR :) ? Wonder if the code is okay for you and reach your expectations. Comments are welcome so I can improve it more. I think that lots of projects would find above features useful.

[zajcu]

@gabrielwalt could you check if this implementation fulfills your requirements from https://github.com/adobe/aem-core-wcm-components/issues/663 We want to follow with your recommendation and have it in our project. These feature is waiting in Code Review quite long, could we speed up the process? Thank you!

[gabrielwalt]

Hi @zajcu, we're currently busy with working on a Data Layer and will likely not be able to make this contribution progress before end of October. I'm really sorry that we lack the capacity to handle such valuable pull requests in a more timely manner. It is however among the top issues in our backlog, so that we can pick it up as soon as we'll have some slack again.

[toniedzwiedz]

Hi @gabrielwalt, what's the plan regarding this feature now that the data layer has been officially released? A client is requesting this feature and it would be great not to write it as a completely custom piece.