aem-core-wcm-components icon indicating copy to clipboard operation
aem-core-wcm-components copied to clipboard

OEmbed Example Configs incorrectly escaping .

Open HitmanInWis opened this issue 1 year ago • 1 comments

Version: 2.25.5-SNAPSHOT

A few of the example OEmbed configs are incorrectly escaping the . in the scheme regex:

com.adobe.cq.wcm.core.components.internal.services.embed.OEmbedClientImplConfigurationFactory-flickr.config

scheme=["https?://.*\.flickr\\.com/photos/.*","https?://flic\\.kr/p/.*"]

should be

scheme=["https?://.*\\.flickr\\.com/photos/.*","https?://flic\\.kr/p/.*"]

com.adobe.cq.wcm.core.components.internal.services.embed.OEmbedClientImplConfigurationFactory-twitter.config

scheme=["https?://(.*\.)?twitter\.com/.*"]

should be

scheme=["https?://(.*\\.)?twitter\\.com/.*"]

com.adobe.cq.wcm.core.components.internal.services.embed.OEmbedClientImplConfigurationFactory-youtube.config

scheme=["https://.*\.youtube.com/watch.*","https://.*\.youtube.com/v/.*","https://youtu\.be/.*"]

should be

scheme=["https://.*\\.youtube.com/watch.*","https://.*\\.youtube.com/v/.*","https://youtu\\.be/.*"]

HitmanInWis avatar Jun 27 '24 14:06 HitmanInWis

I would recommend switching to .cfg.json serialization format, as it has simpler escaping rules and is the native format for Sling Feature Models (and meanwhile also properly supported in AEM 6.5)

kwin avatar Jun 27 '24 17:06 kwin