aem-core-wcm-components icon indicating copy to clipboard operation
aem-core-wcm-components copied to clipboard

SITES-4621 Keep access to unused in between content

Open tyge68 opened this issue 2 years ago • 4 comments

Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Minor: New Feature?
Major: Breaking Change?
Tests Added + Pass? Yes
Documentation Provided Yes (code comments and or markdown)
Any Dependency Changes?
License Apache License, Version 2.0

  • Updated ContentFragment model API to expose the list of "par#" that are not displayed anymore when content structure changed (usually when paragraphs are removed).
  • Updated the ContentFragmentImpl to compute paragraphs and remainingInBetweenContent information
  • Update "templates.html" in order to output remaining in between content at the end.
  • Updated all the related tests

Feel free to commit , reuse this code.

tyge68 avatar Jul 25 '22 14:07 tyge68

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Jul 25 '22 14:07 sonarqubecloud[bot]

Codecov Report

Merging #2261 (d4c393a) into main (e49999b) will increase coverage by 0.00%. The diff coverage is 73.68%.

@@            Coverage Diff            @@
##               main    #2261   +/-   ##
=========================================
  Coverage     86.94%   86.94%           
- Complexity     2479     2487    +8     
=========================================
  Files           217      217           
  Lines          6634     6651   +17     
  Branches       1016     1020    +4     
=========================================
+ Hits           5768     5783   +15     
  Misses          345      345           
- Partials        521      523    +2     
Impacted Files Coverage Δ
...models/v1/contentfragment/ContentFragmentImpl.java 83.58% <72.22%> (-0.74%) :arrow_down:
...onents/models/contentfragment/ContentFragment.java 100.00% <100.00%> (ø)
...core/components/internal/ContentFragmentUtils.java 84.61% <0.00%> (+1.09%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Jul 25 '22 14:07 codecov[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Sep 27 '22 09:09 sonarqubecloud[bot]

@tyge68 hi, any updates on the task? It seems like there is still feedback open and we would like to see that functionally out of the box :)

satzlinger avatar Jul 24 '23 13:07 satzlinger