aem-core-wcm-components
aem-core-wcm-components copied to clipboard
Add sizes capabilities to ImageV3 component
- add sizes attribute to ImageV3 component
- provide auto size capabilities to ImageV3 component
- fix #2042 broken dynamic media support for ImageV3
- fix #2140 encoding issue for dynamic media urls
- fix #1986
Q | A |
---|---|
Fixed Issues? | Fixes #1, Fixes #2 |
Patch: Bug Fix? | |
Minor: New Feature? | |
Major: Breaking Change? | |
Tests Added + Pass? | Yes |
Documentation Provided | Yes (code comments and or markdown) |
Any Dependency Changes? | |
License | Apache License, Version 2.0 |
Codecov Report
Merging #2249 (88837a4) into main (9bffc27) will increase coverage by
0.03%
. The diff coverage is81.81%
.
@@ Coverage Diff @@
## main #2249 +/- ##
============================================
+ Coverage 86.95% 86.98% +0.03%
- Complexity 2471 2474 +3
============================================
Files 217 217
Lines 6621 6622 +1
Branches 1010 1010
============================================
+ Hits 5757 5760 +3
+ Misses 344 342 -2
Partials 520 520
Impacted Files | Coverage Δ | |
---|---|---|
.../core/components/internal/models/v2/ImageImpl.java | 83.33% <0.00%> (ø) |
|
.../core/components/internal/models/v3/ImageImpl.java | 95.65% <88.88%> (+2.89%) |
:arrow_up: |
...com/adobe/cq/wcm/core/components/models/Image.java | 100.00% <100.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
This pull request introduces 2 alerts when merging 75cc4c5fd390a0d39effbcfe258046e44c702d12 into 52aca1f42df2c0d3404d4169b003f10e9218e6df - view on LGTM.com
new alerts:
- 2 for DOM text reinterpreted as HTML
This pull request introduces 2 alerts when merging fa01e296da04fca73574d5f7323f3fc3e39f7ae3 into c4771394492981797bc640a9feed88477b509140 - view on LGTM.com
new alerts:
- 2 for DOM text reinterpreted as HTML
This pull request introduces 2 alerts when merging 6c6cdeff288fedd9c5389926dea75a279d6ef40d into 4b868725971e07a7c340cd93e4ba4fa58439f6e4 - view on LGTM.com
new alerts:
- 2 for DOM text reinterpreted as HTML
This pull request introduces 2 alerts when merging 30a8c8371e7ce699673791348be7b3f76b240e95 into 4b868725971e07a7c340cd93e4ba4fa58439f6e4 - view on LGTM.com
new alerts:
- 2 for DOM text reinterpreted as HTML
@Buuhuu I removed the auto sizes feature and only added a static multifield for the sizes attribute and a fix for the broken dm images in V3 for now.
We can add the auto sizes feature in a separate PR if needed later. Can you please have look to the changes? Thx!
This pull request introduces 1 alert when merging ba260a69226a88fa4e5a403c015c8e8494401142 into 9bffc27cb9a03e31c96247a0fb7f88f92c68a577 - view on LGTM.com
new alerts:
- 1 for DOM text reinterpreted as HTML
This pull request introduces 1 alert when merging 055d06b30eccc0c8fb8cc947f7bb91ae4f2bbd73 into 9bffc27cb9a03e31c96247a0fb7f88f92c68a577 - view on LGTM.com
new alerts:
- 1 for DOM text reinterpreted as HTML
SonarCloud Quality Gate failed.
0 Bugs
0 Vulnerabilities
2 Security Hotspots
45 Code Smells
No Coverage information
4.5% Duplication
This pull request introduces 1 alert when merging 88837a4f4c81d0c8b56d16e4f60ea18ed4f4ccf8 into 9bffc27cb9a03e31c96247a0fb7f88f92c68a577 - view on LGTM.com
new alerts:
- 1 for DOM text reinterpreted as HTML
@vladbailescu I addressed your findings in a new PR at https://github.com/adobe/aem-core-wcm-components/pull/2288. Can you please have a look. Thx!