aem-core-wcm-components icon indicating copy to clipboard operation
aem-core-wcm-components copied to clipboard

Published 20 hours ago • verified publisher icon adobe

FIX: Issue 2099 - Prevents Accordion to throw an error when selecting an element by URL hash

Open fagnervalente opened this issue 2 years ago • 1 comments

Q                       A
Fixed Issues? Fixes #2099
Patch: Bug Fix? Yes
Minor: New Feature?
Major: Breaking Change?
Tests Added + Pass? Yes
Documentation Provided Yes (code comments and or markdown)
Any Dependency Changes?
License Apache License, Version 2.0

I've add a check if the hash starts with a number, if so, it will not go ahead with the onHashChange function and will avoid the error on try to select a element with a invalid CSS selector.

fagnervalente avatar Mar 18 '22 20:03 fagnervalente

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Mar 18 '22 21:03 sonarqubecloud[bot]

@fagnervalente This issue was meanwhile fixed with https://github.com/adobe/aem-core-wcm-components/pull/2138. But thank you very much for the hands up and the PR!

bpauli avatar Sep 01 '22 18:09 bpauli