aem-core-wcm-components icon indicating copy to clipboard operation
aem-core-wcm-components copied to clipboard

[Accessibility][Carousel] Previous buttons need an accessible label

Open Gajalakshmi0408 opened this issue 3 years ago • 6 comments

Component : core/wcm/components/carousel/v1/carousel Current behavior Previous/Next buttons are announced by screen-readers, but cannot be authored/modified on page since it is fetched from i18n value.

Expected behavior/code To make the Previous/Next buttons to be authorable as part of the cq:dialog .

Affected Users Screen reader users

Possible Solution

  1. Make the Previous/Next buttons to be authorable.
  2. Introduce an aria-label attribute for Previous/Next buttons for Accessibility purpose.

Gajalakshmi0408 avatar Mar 09 '22 13:03 Gajalakshmi0408

@gabrielwalt Can we make the Previous/Next button to be authorable so that authors will have flexibility to change it. With the current code structure, the screen reader will narrate as Previous & Next buttons. This might not be understood by many screen reader users. If we have the authoring field/aria-labels for buttons, we can give the inputs like "Previous slide" and "Next Slide", which will be understandable to the screen-reader users.

Gajalakshmi0408 avatar Apr 07 '22 10:04 Gajalakshmi0408

@gabrielwalt Do we have any update on this ticket? Please let me know for any further clarification/s needed from my end.

Gajalakshmi0408 avatar Apr 18 '22 13:04 Gajalakshmi0408

@gabrielwalt Do we have any clarification needed/justification on this ticket please?

Gajalakshmi0408 avatar May 11 '22 06:05 Gajalakshmi0408

@adobe export issue to Jira project SITES

gabrielwalt avatar May 18 '22 09:05 gabrielwalt

:white_check_mark: Jira issue SITES-6345 is successfully created for this GitHub issue.

github-jira-sync-bot avatar May 18 '22 09:05 github-jira-sync-bot

To make the accessibility labels of the carousel component more customizable by the author, we'd need the following:

  • Text inputs to set the "Previous", "Next", "Play", and "Pause" button labels.
  • Text input to set the "Choose a slide to display" aria label.
  • Checkbox to use the carousel names in the aria labels (instead of the "Slide 1...N" labels). This checkbox could be enabled by default for new carousels that are added to the page - but kept as is for existing content.

This issue has been made part of our current sprint.

gabrielwalt avatar May 18 '22 09:05 gabrielwalt

Fixed by #2210

vladbailescu avatar Sep 01 '22 07:09 vladbailescu