aem-core-wcm-components icon indicating copy to clipboard operation
aem-core-wcm-components copied to clipboard

fix(page): skiptomain RTL

Open fraudoudou opened this issue 3 years ago • 3 comments

  • alignment of "skip to main"-link for RTL languages
  • remove nesting so it's BEM-compliant

#1265

Q                       A
Fixed Issues? #1265
Patch: Bug Fix? 👍
Minor: New Feature? 👎
Major: Breaking Change? 👎
Tests Added + Pass? Yes
Documentation Provided No update
Any Dependency Changes? No
License Apache License, Version 2.0

fraudoudou avatar Apr 27 '21 09:04 fraudoudou

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Apr 27 '21 09:04 sonarqubecloud[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Jul 08 '22 14:07 sonarqubecloud[bot]

Codecov Report

Merging #1540 (07323f2) into main (8400645) will decrease coverage by 0.10%. The diff coverage is n/a.

:exclamation: Current head 07323f2 differs from pull request most recent head c7a0eab. Consider uploading reports for the commit c7a0eab to get more accurate results

@@             Coverage Diff              @@
##               main    #1540      +/-   ##
============================================
- Coverage     86.98%   86.87%   -0.11%     
+ Complexity     2475     2455      -20     
============================================
  Files           217      217              
  Lines          6623     6577      -46     
  Branches       1011     1002       -9     
============================================
- Hits           5761     5714      -47     
- Misses          342      345       +3     
+ Partials        520      518       -2     
Impacted Files Coverage Δ
.../core/components/internal/models/v3/ImageImpl.java 92.75% <0.00%> (-2.90%) :arrow_down:
...al/services/LatestVersionImplementationPicker.java 90.90% <0.00%> (-1.95%) :arrow_down:
...onents/internal/servlets/AdaptiveImageServlet.java 77.73% <0.00%> (-0.18%) :arrow_down:
...core/components/internal/link/LinkBuilderImpl.java 96.29% <0.00%> (-0.14%) :arrow_down:
.../core/components/internal/models/v2/ImageImpl.java 83.33% <0.00%> (-0.12%) :arrow_down:
.../com/adobe/cq/wcm/core/components/models/Page.java 100.00% <0.00%> (ø)
...com/adobe/cq/wcm/core/components/models/Image.java 100.00% <0.00%> (ø)
...m/core/components/internal/models/v3/PageImpl.java 100.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Jul 08 '22 14:07 codecov[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Sep 01 '22 20:09 sonarqubecloud[bot]