[Container] Missing @Exporter annotation - JSON output skipped in model.json Export

[stefanseifert]

Fixes #1407

[sonarqubecloud[bot]]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
1.1% Duplication

[jckautzmann]

It would be nice to add a unit test to verify that the JSON output of the container component is available.

[stefanseifert]

unit tests are already in place. the absence of this annotation does not change the result in unit tests. it would only be possible to test it in integration tests from outside testing the model.json output.

[vladbailescu]

I can see this breaking different use cases. Right now, with the missing annotations, the ResponsiveGrid exporter is used (through inheritance chain). We will probably need to ensure that when responsiveGrid layout is used we include the export from the ResponsiveGrid as well.

[stefanseifert]

yes, this can definitely break applications relying on the "wrong" output of the ResponsiveGrid model. i do not see a benefit to switch models for simple/responsive layout - the output of the old ResponsiveGrid is really not well suited for JSON export (outputting a lot of authoring-related stuff like allowedComponents which should not be contained in the JSON output).

a pity this annotation was not in place when the container was introduced. probably now this change has to be postponed to version 3.0.0 to no break things, this would be a clean cut.

[sonarqubecloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[codecov[bot]]

Codecov Report

Merging #1408 (2945108) into main (f49a734) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1408   +/-   ##
=========================================
  Coverage     86.84%   86.84%           
  Complexity     2433     2433           
=========================================
  Files           216      216           
  Lines          6523     6523           
  Branches       1003     1003           
=========================================
  Hits           5665     5665           
  Misses          342      342           
  Partials        516      516           

Impacted Files	Coverage Δ
...onents/internal/models/v1/LayoutContainerImpl.java	100.00% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f49a734...2945108. Read the comment docs.