aem-core-wcm-components icon indicating copy to clipboard operation
aem-core-wcm-components copied to clipboard

Published 20 hours ago • verified publisher icon adobe

HTML container component

Open bschuhma opened this issue 4 years ago • 2 comments

Q                       A
Fixed Issues? New component - HTML Container component
Patch: Bug Fix?
Minor: New Feature?
Major: Breaking Change?
Tests Added + Pass? No - **** TO-DO -
Documentation Provided Yes (code comments and or markdown)
Any Dependency Changes?
License Apache License, Version 2.0

The HTML component addresses customers' needs/desires to write their own HTML, while implementing some element of formality by forcing them to use only files in the DAM. Instead of customers just free-handing code that hasn't undergone any form of peer review, hopefully this component will force them to review the HTML/CSS/JS and put it into the DAM.

The component allows for multiple CSS and JS files to support the one HTML file. The CSS files can be brought in inline or via reference, while the JS files can be brought in via async, defer, reference and inline.

bschuhma avatar Sep 18 '20 17:09 bschuhma

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 42 Code Smells

No Coverage information No Coverage information
82.2% 82.2% Duplication

sonarqubecloud[bot] avatar Sep 18 '20 18:09 sonarqubecloud[bot]

This pull request introduces 10 alerts when merging 0a991465e3646326f126f21a0863e803fc15030e into 19c0a147e244c6c19bac1ccdcf0a1b87edaa3a08 - view on LGTM.com

new alerts:

  • 6 for Implicit operand conversion
  • 3 for Variable not declared before use
  • 1 for Potential input resource leak

lgtm-com[bot] avatar Sep 18 '20 18:09 lgtm-com[bot]