FORMS-18631: Desktop, RWD Tablet, RWD Mobile - Grid: Grid is missing appropriate roles and/or attributes @sunnym @vavarshn

[CezarSTF]

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• [ ] I have signed the Adobe Open Source CLA.
• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [ ] I have read the CONTRIBUTING document.
• [ ] I have added tests to cover my changes and the overall coverage did not decrease.
• [ ] All unit tests pass on CircleCi.
• [ ] I ran all tests locally and they pass.

[codecov[bot]]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests.

:loudspeaker: Thoughts on this report? Let us know!

[adobe-bot]

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

[adobe-bot]

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

[CezarSTF]

Moved the datepicker changes to v2.

[CezarSTF]

Hello @im-shiv ! I took a look over other components that have multiple versions (especially the wizard component), and I tried to apply the same to the datepicker component. Please provide feedback.

[adobe-bot]

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

[adobe-bot]

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

[adobe-bot]

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

[adobe-bot]

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

[adobe-bot]

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

[adobe-bot]

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

[im-shiv]

@CezarSTF just update the license year. in all the files. Since it's a new version of date picker, following files also needs updation to use new version: https://github.com/adobe/aem-core-forms-components/blob/master/ui.af.apps/pom.xml#L343 https://github.com/adobe/aem-core-forms-components/blob/master/ui.af.apps/src/main/content/jcr_root/apps/core/fd/af-clientlibs/core-forms-components-runtime-all-xfa/.content.xml#L8 https://github.com/adobe/aem-core-forms-components/blob/master/ui.af.apps/src/main/content/jcr_root/apps/core/fd/af-clientlibs/core-forms-components-runtime-all/.content.xml#L8

and in this for test cases https://github.com/adobe/aem-core-forms-components/blob/master/it/apps/src/main/content/jcr_root/apps/forms-core-components-it/clientlibs/custom-forms-components-runtime-all/.content.xml#L8

[im-shiv]

@CezarSTF also, have you verified the changes locally? we also need to have test cases which are being added in this newer version of datepicker

[CezarSTF]

@im-shiv

• I updated the copyright year for all the changed or added files
• I updated the version for all the mentioned files
• I added the test cases specific for the v2 datepicker component (I took these as example: https://github.com/adobe/aem-core-forms-components/blob/master/ui.tests/test-module/specs/button/buttonv2.runtime.cy.js and https://github.com/adobe/aem-core-forms-components/blob/master/ui.tests/test-module/specs/title/titlev2.runtime.cy.js) where I added the test cases for the bug fixes I've commited in this PR.
• I will provide screenshots/screen recordings of how this behaves locally.

[CezarSTF]

@im-shiv This is how the datepicker v2 is looking locally