aem-core-cif-components
aem-core-cif-components copied to clipboard
Included "Relevance" as one of the sort option
Included "Relevance" as one of the sort option since there are no option to extend the SearchOptions class and modified as per the Project need
Description
ProductListImpl (com.adobe.cq.commerce.core.components.internal.models.v1.productlist) has been modified to include an additional option of sort by relevance and the required test classes are modified .
Related Issue
Its a new feature that need to be added to support project need and also it has been discussed with Marcus
Motivation and Context
Add this option will help the project team to leverage the sort by relevance option in the Product List component
How Has This Been Tested?
Code has been locally deployed to AEM Cloud SDK and validated the product list component
Screenshots (if appropriate):
Types of changes
- [ ] New feature (non-breaking change which adds functionality)
Checklist:
- [ ] I have signed the Adobe Open Source CLA.
x
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] I have read the CONTRIBUTING document.
x
- [ ] I have added tests to cover my changes and the overall coverage did not decrease.
x
- [ ] All unit tests pass on CircleCi.
- [ ] I ran all tests locally and they pass.
x
Codecov Report
Merging #714 (9b02523) into master (f8bf32c) will decrease coverage by
1.22%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #714 +/- ##
============================================
- Coverage 88.21% 86.99% -1.23%
============================================
Files 287 151 -136
Lines 7223 3152 -4071
Branches 1058 518 -540
============================================
- Hits 6372 2742 -3630
+ Misses 637 410 -227
+ Partials 214 0 -214
Flag | Coverage Δ | |
---|---|---|
jest | 85.92% <ø> (ø) |
|
karma | 89.95% <ø> (ø) |
|
unittests | ? |
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f8bf32c...9b02523. Read the comment docs.
@Sambasivaraj the PR LGTM but can you sign the Adobe Open Source CLA. Thx.