aem-boilerplate icon indicating copy to clipboard operation
aem-boilerplate copied to clipboard

Minified martech plugin fails causes build to fail due to linting

Open johndavidsimmons opened this issue 1 year ago • 2 comments

Expected Behaviour

Installing AEM Martech Plugin passes linting and builds successfully

Actual Behaviour

Installing Martech plugin causes builds to fail due to linting errors. Build process is linting minified files.

Reproduce Scenario (including but not limited to)

  1. Make a new site using the boilerplate code.
  2. Install the AEM Martech plugin
  3. Commit & Push to main triggering the build process
  4. Build fails due to linting errors in minified martech plugin files

Sample Code that illustrates the problem

https://github.com/johndavidsimmons/aem-demo-site

johndavidsimmons avatar Dec 05 '24 15:12 johndavidsimmons

Since this is throwing errors on a minified file, I see 3 options here:

  1. we explicitly call out in the martech lib documentation that you need to update your project's .eslintignore
  2. we add a generic *.min.js in the boilerplate's .eslintignore
  3. we consider it's the project team's responsibility to figure out what .eslintignore config to use based on the what they add to the boilerplate

I'm temped to do 1. and 3., but 2. would be a more generic future-proof approach… but this addresses something outside the scope of the boilerplate itself.

@kptdobe what's your take on this?

ramboz avatar Dec 05 '24 17:12 ramboz

I agree option 2 would make sense: the chance a minified file passes the linting is really low...

kptdobe avatar Dec 09 '24 11:12 kptdobe