S3Mock icon indicating copy to clipboard operation
S3Mock copied to clipboard

Published 20 hours ago • verified publisher icon adobe

wip support s3 conditional writes

Open sullis opened this issue 1 year ago • 1 comments

Description

support s3 conditional writes

Related Issue

https://aws.amazon.com/about-aws/whats-new/2024/08/amazon-s3-conditional-writes/

Tasks

  • [x] I have signed the CLA.
  • [ ] I have written tests and verified that they fail without my change.

sullis avatar Oct 06 '24 21:10 sullis

This is an early draft. I am looking for feedback. cc: @afranken

sullis avatar Oct 17 '24 22:10 sullis

@sullis thanks for your patience. I was actually mistaken in my comment here: https://github.com/adobe/S3Mock/issues/2084#issuecomment-2393477594

If-Match and If-None-Match headers are already implemented, and a tests similar to the one you added already exist, see line 626 and following: https://github.com/adobe/S3Mock/blob/main/integration-tests/src/test/kotlin/com/adobe/testing/s3mock/its/GetPutDeleteObjectV2IT.kt#L626

Only If-modified-since requests are currently not implemented, which are a form of conditional reads and writes. I added that capability with this PR: https://github.com/adobe/S3Mock/pull/2170

afranken avatar Dec 15 '24 23:12 afranken