afdko icon indicating copy to clipboard operation
afdko copied to clipboard

Update makeinstancesufo to use latest ufoProcessor

Open punchcutter opened this issue 1 year ago • 4 comments

This makes use of the "new" way to use ufoProcessor with UFOOperator. This allows passing the --strict flag from makeinstancesufo to ufoProcessor which passes to fontMath. From fontMath.mathGlyph:

strict (bool): when set to False, offcurve points will be added to all
                straight segments to improve compatibility. Any offcurves that are
                still on-point will be filtered when extracted. When set to True,
                no offcurves will be added or filtered.

This means when making an "Instance" to be inserted back into the designspace we won't run into the situation where points are filtered out, making the new instance incompatible with the original sources.

punchcutter avatar Aug 30 '24 02:08 punchcutter

~~Oh yeah, tests fail because we need an update to ufoProcessor -> https://github.com/LettError/ufoProcessor/pull/64.~~ ufoProcessor updated to 1.13.1

punchcutter avatar Aug 30 '24 03:08 punchcutter

This introduces a number of changes to the expected output UFOs, but I believe all of it makes sense and in some cases is now "more correct" so that's a good thing.

punchcutter avatar Sep 04 '24 05:09 punchcutter

@josh-hadley I believe you were more involved in the discussions about this -- everything look good to you?

skef avatar Sep 06 '24 23:09 skef

@josh-hadley I believe you were more involved in the discussions about this -- everything look good to you?

Right, I've been informally chatting with @punchcutter about this. This looks good to me and will solve some longstanding annoyances.

josh-hadley avatar Sep 09 '24 16:09 josh-hadley