afdko icon indicating copy to clipboard operation
afdko copied to clipboard

remove PUA code points from resource files

Open frankrolf opened this issue 2 years ago • 3 comments

Upon a rebuild of the FDK, this should probably address #1662.

Description

This commit is deleting any glyph name associated with a PUA code points from AGD.txt, and (probably more importantly) agl2uv.h.

The assumption is that makeotfexe will no longer unexpectedly assign PUA code points. I don’t have a way to test this locally (or I don’t know) – would be curious to figure out what the next steps are.

frankrolf avatar Sep 29 '23 17:09 frankrolf

I guess this means that some of the expected CJK fonts contain PUA glyphs :-)

frankrolf avatar Sep 29 '23 18:09 frankrolf

I guess this means that some of the expected CJK fonts contain PUA glyphs :-)

No — these test failures are caused by a change in fontTools v4.43.0, unrelated to your changes around removing PUAs.

josh-hadley avatar Sep 29 '23 22:09 josh-hadley

@frankrolf once #1715 is merged, rebase this and it should pass. I'm still not convinced of the need to change AGD.txt but I guess it makes sense to keep its contents in sync with what makeotf[exe] is doing.

josh-hadley avatar Sep 30 '23 01:09 josh-hadley