svgObjectModelGenerator icon indicating copy to clipboard operation
svgObjectModelGenerator copied to clipboard

No support for text wrapping

Open dirkschulze opened this issue 10 years ago • 12 comments

Photoshop support auto wrapping of text. SVG doesn't have that yet. We need to simulate it. Generator does not provide all needed information about this yet. JS doesn't help here, since we export SVG images which are not allowed to run scripts.

See https://github.com/adobe-photoshop/generator-core/issues/250

dirkschulze avatar Aug 15 '14 07:08 dirkschulze

This is critical for Crema - otherwise, we don't have feature parity with the older generator svg engine.

joebowden avatar Aug 22 '14 21:08 joebowden

Not sure what you mean, the old engine doesn't have text wrapping.

dirkschulze avatar Aug 22 '14 21:08 dirkschulze

The old engine supports hard returns for multiline text.

joebowden avatar Aug 22 '14 21:08 joebowden

We do as well. We even have multiple tests for that.

dirkschulze avatar Aug 22 '14 21:08 dirkschulze

Hmm...I do see separate lines, but they're overlapping. Is that expected?

joebowden avatar Aug 22 '14 21:08 joebowden

no, could you send me your test please?

dirkschulze avatar Aug 23 '14 05:08 dirkschulze

Thanks Dirk - emailed a test file.

joebowden avatar Aug 23 '14 21:08 joebowden

Need to fix this for parity with CC Extract's SVG output.

nimbupani avatar Aug 30 '14 17:08 nimbupani

Request has been submitted to Generator a while back ago. It seems that we disagree on expectations of developers with the Generator team: https://github.com/adobe-photoshop/generator-core/issues/250

dirkschulze avatar Aug 31 '14 10:08 dirkschulze

Hard returns are working now in Crema. We would have parity with Extract if we supported paragraph text with soft returns.

Here's a test file that Crema currently does not wrap the text for: http://adobe.ly/1lODgkY

@dirkschulze, extract/graphite handles the soft returns using t-span elements, which of course don't actually wrap in a browser - but, that is the kind of parity that Crema is looking for with extract right now. Is that a different issue than this one?

joebowden avatar Sep 07 '14 04:09 joebowden

Hard returns should have worked from the beginning in svgOMG. The soft returns is what I was after. And yes, this can just be implemented with more tspans. Just like we do for hard returns.

dirkschulze avatar Sep 07 '14 05:09 dirkschulze

I'm actively working on this.

mvujovic avatar Dec 09 '14 00:12 mvujovic