svgObjectModelGenerator icon indicating copy to clipboard operation
svgObjectModelGenerator copied to clipboard

Transforms are not being mapped properly

Open jhatwich opened this issue 10 years ago • 14 comments

Needs test media and more information.

I am seeing problems with whack transforms when isolating a single layer. The test case I'm looking at is text on a path, but I think the problem at least includes other kinds of text if not all transforms in the isolated context.

jhatwich avatar Sep 09 '14 14:09 jhatwich

I'll add some test files.

joebowden avatar Sep 09 '14 16:09 joebowden

Here's a smoke file for shapes: http://adobe.ly/1wbWwMm

(warp, flip horizontal, & flip vertical currently generate correctly)

joebowden avatar Sep 09 '14 17:09 joebowden

Here's one with group transforms: http://adobe.ly/1nJgm9Q

(rotate & scale seem to generate svg correctly)

joebowden avatar Sep 09 '14 17:09 joebowden

Regression test file for QE: https://www.dropbox.com/s/7ax350b44e3s7ov/iOS7-Discover.psd?dl=0

From this issue: https://git.corp.adobe.com/edgecclayout/crema/issues/378 - Post.svg is not rendering - it has a transform matrix.

joebowden avatar Sep 09 '14 19:09 joebowden

Here is the one I was looking at where I noticed it first... (could be other issues at play too)...

https://drive.google.com/a/601t.com/file/d/0B1M3zV5eEym9OVlvdk5nNk1mdTg/edit?usp=sharing

jhatwich avatar Sep 10 '14 01:09 jhatwich

Ok, it looks like the rawPath has the transformed path. It would of course be great if we can get the transform directly and we could preserve the shape type instead.

The current problem for shapes is just that we don't know if we have to use the rawPath or the shape directly. There doesn't seem to be a hint in the JSON file.

dirkschulze avatar Sep 10 '14 09:09 dirkschulze

Here is the bug report for generator-core https://github.com/adobe-photoshop/generator-core/issues/265

dirkschulze avatar Sep 10 '14 09:09 dirkschulze

For simple shapes it seems like we could work-around by writing the equivalent raw path and compare it to see if has been transformed... hackey, but seems like it might work. Worthwhile to look into this?

I'm thinking not since we would just end up with a raw path, not simple shape + transform like we really want.

jhatwich avatar Sep 10 '14 15:09 jhatwich

blocked on the generator-core bug. considering adding an errors.txt warning.

jhatwich avatar Sep 10 '14 22:09 jhatwich

when fixed, please regress with testfile from https://git.corp.adobe.com/edgecclayout/crema/issues/403 (closed as duplicate with this bug)

imaderyc avatar Sep 11 '14 04:09 imaderyc

PS team logged the rotate case in Watson: https://watsonexp.corp.adobe.com/#bug=3822063

joebowden avatar Sep 11 '14 23:09 joebowden

Another issue from Seth Walker: https://git.corp.adobe.com/edgecclayout/crema/issues/594

joebowden avatar Sep 17 '14 21:09 joebowden

PS team logged another on transformed text: https://watsonexp.corp.adobe.com/#bug=3827889

joebowden avatar Sep 19 '14 18:09 joebowden

another watson bug: 3849215

imaderyc avatar Jan 26 '15 19:01 imaderyc